Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit convetion terms should fail when the equation has no TransientTerm (dt=None) #319

Closed
wd15 opened this issue Sep 19, 2014 · 3 comments

Comments

@wd15
Copy link
Contributor

wd15 commented Sep 19, 2014

This ticket was prompted by a question on the mailing list where the user was using an explicit convection term with a steady state solution but was getting no error and a cryptic error in the case of the van Leer convection term.

http://thread.gmane.org/gmane.comp.python.fipy/2555/focus=2556

Plan to throw a sensible error if dt is None.

Imported from trac ticket #441, created by wd15 on 05-02-2012 at 12:01, last modified: 09-30-2013 at 21:44

@wd15
Copy link
Contributor Author

wd15 commented Sep 19, 2014

Explicit convection terms now throw a suitable error when used without a transient term. See r5231.

Trac comment by wd15 on 05-10-2012 at 15:56

@fipymigrate
Copy link

In 552a4ae:

#CommitTicketReference repository="fipy" revision="552a4ae50ad316edd3cd2646d23583303fedc3d1"
* Fixed issue #319.

 * Fixed an issue with term's _checkVar method that was never being
   called if the term was part of a binary equation.



git-svn-id: svn+ssh://code.matforge.org/fipy/branches/ticket441@5229 d80e17d7-ff13-0410-a124-85740d801063

Trac comment by Daniel Wheeler daniel.wheeler@nist.gov on 06-12-2013 at 14:14

@guyer
Copy link
Member

guyer commented Sep 19, 2014

Marking milestone

Trac comment by guyer on 09-30-2013 at 21:44

@wd15 wd15 closed this as completed Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants