From cc555318b95b073ff3446799e7718c4ad26e6b4f Mon Sep 17 00:00:00 2001 From: Jonathan Guyer Date: Fri, 14 Jun 2019 16:32:14 -0400 Subject: [PATCH] Issue557 face grad average is stupid (#653) * Deprecate .faceGradAverage * Remove old deprecation --- fipy/meshes/abstractMesh.py | 5 ----- fipy/variables/cellVariable.py | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fipy/meshes/abstractMesh.py b/fipy/meshes/abstractMesh.py index 0b41103842..7b300733d6 100644 --- a/fipy/meshes/abstractMesh.py +++ b/fipy/meshes/abstractMesh.py @@ -98,11 +98,6 @@ def faceCenters(self): cellDistanceVectors = property(lambda s: s._cellDistanceVectors) cellVolumes = property(lambda s: s._scaledCellVolumes) - @property - @deprecate(new_name="faceNormals", version=3.1) - def _faceNormals(self): - return self.faceNormals - @property def cellCenters(self): from fipy.variables.cellVariable import CellVariable diff --git a/fipy/variables/cellVariable.py b/fipy/variables/cellVariable.py index 65eca6f95e..3328b48751 100644 --- a/fipy/variables/cellVariable.py +++ b/fipy/variables/cellVariable.py @@ -3,6 +3,7 @@ from fipy.variables.meshVariable import _MeshVariable from fipy.tools import numerix +from fipy.tools.decorators import deprecate __all__ = ["CellVariable"] from future.utils import text_to_native_str @@ -402,6 +403,7 @@ def faceGrad(self): return self._faceGrad @property + @deprecate(new_name="grad.arithmeticFaceValue", version=3.3) def faceGradAverage(self): r""" Return :math:`\nabla \phi` as a rank-1 `FaceVariable` using averaging