Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP800-56C r1 OneStep general error #8

Closed
smuellerDD opened this issue Sep 18, 2020 · 6 comments
Closed

SP800-56C r1 OneStep general error #8

smuellerDD opened this issue Sep 18, 2020 · 6 comments
Assignees

Comments

@smuellerDD
Copy link

environment
Demo

testSessionId
not yet awarded

vsId
N/A

Algorithm registration

      {
        "prereqVals":[
          {
            "algorithm":"SHA",
            "valValue":"same"
          },
          {
            "algorithm":"HMAC",
            "valValue":"same"
          },
          {
            "algorithm":"DRBG",
            "valValue":"same"
          }
        ],
        "algorithm":"KAS-KDF",
        "mode":"OneStep",
        "revision":"Sp800-56Cr1",
        "l":1024,
        "z":[
          {
            "min":256,
            "max":512,
            "increment":128
          }
        ],
        "auxFunctions":[
          {
            "auxFunctionName":"HMAC-SHA2-256",
            "macSaltMethods":[
              "default",
              "random"
            ]
          },
          {
            "auxFunctionName":"SHA2-256",
            "macSaltMethods":[
              "random"
            ]
          }
        ],
        "fixedInfoPattern":"uPartyInfo||vPartyInfo||literal[affedeadbeef]",
        "encoding":[
          "concatenation"
        ]
      },

Endpoint in which the error is experienced
POST /acvp/v1/testSessions

[
  {
    "acvVersion": "1.0"
  },
  {
    "error": "Validation error(s) on JSON payload.",
    "context": [
      "KAS-KDF-OneStep-Sp800-56Cr1: General exception. Contact service provider."
    ]
  }
]
@smuellerDD
Copy link
Author

Sorry, typo in registration

@Kritner
Copy link
Contributor

Kritner commented Sep 18, 2020

@smuellerDD what was the typo? That wasn't a good error response to return from our end, probably dealing with an NRE on the property that wasn't provided. I'd like to fix that so a more meaningful error message is returned.

@Kritner Kritner reopened this Sep 18, 2020
@smuellerDD
Copy link
Author

smuellerDD commented Sep 18, 2020 via email

@Kritner Kritner self-assigned this Sep 18, 2020
@Kritner
Copy link
Contributor

Kritner commented Sep 18, 2020

ah thanks, I'll put in a fix for that.

@Kritner
Copy link
Contributor

Kritner commented Sep 24, 2020

A fix for this is on demo BTW (the issue with the transposed registration vs algorithm identifier)

@Kritner Kritner closed this as completed Sep 24, 2020
@Kritner
Copy link
Contributor

Kritner commented Sep 30, 2020

this change is now on production https://github.com/usnistgov/ACVP-Server/releases/tag/v1.1.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants