Missing test vector files for SHA3-384 and SHA3-512

[dspdon]

Test vector files for SHA3-224 and SHA3-256 appear in:
https://github.com/usnistgov/ACVP-Server/blob/master/gen-val/json-files/

However, there are no files for SHA3-384 and SHA3-512.

Can these be added?

--Don

[livebe01]

Hi @dspdon, we'll take a look. This is something we can probably do and I can see how it would be useful.
We don't necessarily include test vectors for every possible algorithm at https://github.com/usnistgov/ACVP-Server/blob/master/gen-val/json-files/. The main reason is that the process that creates the sample test vector files is also used as part of our development, test, build, release process. If we included every algorithm and every option in it, it's more stuff we're waiting on to run when we're doing testing as part of the development/build/release processes.

[dspdon]

Thanks for that insight. I can certainly confirm the usefulness of these files (new implementation testing, existing cipher-suite smoke-testing, etc). I view these files as a product that you deliver, not a by-product. That may stretch the intended scope of ACVP.

A goal to provide one test file for every NIST-approved algorithm is implied by this request. I see where that gets to be quite a few files to generate.

How to expand support without negatively impacting your development workflow seems practical. Have you thought about building these files less frequently - say, daily or weekly or at certain releases? Or a subset of files reproduced with each build as it is done today, but a more comprehensive set of files produced less frequently? A revision line could clarify the correspondence of test files to ACVP-Server build revision.

[livebe01]

Per #340, consider adding sample JSON files for SHAKE-256 to https://github.com/usnistgov/ACVP-Server/tree/master/gen-val/json-files.

[dspdon]

Thank you for considering. I do appreciate the practical constraints you have on this.

[jbrock24]

I've modified the testing and we will produce SHAKE files for both algos, and I added more SHA3 examples for 384 and 512. These aren't one off and are a part of the testing suite for auto production and inclusion. This will go out with next release alongside the SHAKE 2.0 update. Ben will update this when Release goes live to Demo. Thanks for the feedback @dspdon.

[dspdon]

Thank you!