Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error-message when trying to create new role is not making sense #3836

Closed
Angamanga opened this issue Jan 28, 2020 · 5 comments · Fixed by #3837
Closed

Error-message when trying to create new role is not making sense #3836

Angamanga opened this issue Jan 28, 2020 · 5 comments · Fixed by #3837

Comments

@Angamanga
Copy link
Contributor

Describe the bug
When trying to save a new role, and no Name or associated permissions is added, the error-message that appears is not informative:

Screenshot 2020-01-28 at 13 11 40

Where was the bug observed
https://annatest1000.ushahidi.io/settings/roles/create

To Reproduce
Steps to reproduce the behavior:

  1. Login as admin
  2. Go to settings-> Roles-> create a new role
  3. Do not fill in name or role
  4. Click on save
@rowasc
Copy link
Contributor

rowasc commented Jan 30, 2020

#3837 got bored waiting for tests to run and fixed this one.. I think ? 😬

@Angamanga
Copy link
Contributor Author

Angamanga commented Mar 16, 2020

@Obadha2 Could you QA in Steve Buscemi?
Testing-checklist:

  1. Login as admin
  2. Go to settings-> Roles-> create a new role
  3. Do not fill in name or role
  4. Click on save
  • The error-message should look something like this:
    Screenshot 2020-03-16 at 10 56 45

@AmTryingMyBest
Copy link
Contributor

QA'd. While this passes, could we have "name must not be empty" appear just once, instead of twice? @Angamanga

@Angamanga
Copy link
Contributor Author

I think there is a reason for that I don't remember (even if it is pretty confusing). Do you remember @rowasc ?

@rowasc
Copy link
Contributor

rowasc commented Mar 18, 2020

yea... I think it's just a bad UI , it happens for other fffields too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants