Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected Card In Data View Does Not Display The Survey Color #2356

Closed
3 of 5 tasks
dalezak opened this issue Dec 12, 2017 · 4 comments · Fixed by ushahidi/platform-client#1425
Closed
3 of 5 tasks
Labels
Bug Community Task Issues that the Ushahidi OSS community is encouraged to contribute to good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Hacktoberfest Issues open to folks participating in hacktoberfest
Milestone

Comments

@dalezak
Copy link

dalezak commented Dec 12, 2017

Expected behaviour

The selected card in the data view, should display the correct survey color on the left side of the card.

Actual behaviour

The selected card always just shows the default grey color instead.

Expected behaviour

screenshot 2017-12-12 12 31 17_preview

Steps to reproduce the behaviour/error

  • Set the color in your survey settings
    • Settings
    • Survey
    • select your survey
    • click the Configure tab and scroll to the bottom. You will see a color picker that you can change Screen Shot 2019-11-15 at 15 53 25
    • go to the data view. (If there are no posts for that survey, create one. )
    • See the lists of posts. You will see the color you selected on the selected card border in the list.
    • Click the card/post. You will see the post details. The color in the detail view will be grey instead of your selected color

Example:
Screen Shot 2019-11-15 at 15 52 28

Tips for solving

Change backgroundColor to background-color in the post-detail-data.html file where we use the post-band

Where

Aha! Link: https://ushahiditeam.aha.io/features/PROD-467

@dalezak dalezak added the Bug label Dec 12, 2017
@rowasc rowasc added P3 - Low good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Hacktoberfest Issues open to folks participating in hacktoberfest and removed P2 - Normal labels Sep 28, 2018
@rowasc rowasc added Community Task Issues that the Ushahidi OSS community is encouraged to contribute to and removed Community Task Issues that the Ushahidi OSS community is encouraged to contribute to labels Oct 29, 2018
@komalsdg
Copy link

Hi, @dalezak I am an outreachy applicant and would like to work on this issue.

@NidhiKJha
Copy link

NidhiKJha commented Mar 24, 2019

Cannot reproduce. The cards don't show any colors in the current code. @rowasc @Angamanga

@Angamanga Angamanga removed Hacktoberfest Issues open to folks participating in hacktoberfest P3 - Low labels Apr 29, 2019
@rowasc rowasc added the Hacktoberfest Issues open to folks participating in hacktoberfest label Sep 28, 2019
@Angamanga
Copy link
Contributor

Angamanga commented Feb 12, 2020

@Obadha2 Can you QA in Steve Buscemi please?
Testing checklist:

  • Make sure your surveys is configured with colors (go to settings->survey->select survey->configure)
  • Add a post to a survey with colors
  • Go to dataview
  • Select the post
  • the selected post on the right hand view should have the correct color-band for that post
  • select another post from another survey
  • the selected post on the right hand view should have the correct color-band for that post

@Angamanga Angamanga reopened this Feb 12, 2020
@AmTryingMyBest
Copy link
Contributor

QA'd, passes. 👍

@rowasc rowasc added this to the Parking Lot milestone Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Community Task Issues that the Ushahidi OSS community is encouraged to contribute to good-first-issue Issues that are ideal for first time contributors to OSS or first time contributing to the platform Hacktoberfest Issues open to folks participating in hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants