-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack Bundle for the VS Code extension is not including any node_modules
dependencies
#17
Comments
node_modules
dependenciesnode_modules
dependencies
I forked the project to implement a fix, but the issues end up going much deeper.
I was able to solve the WebPack issues, but then ran in to some of the above issues. The primary blocker in the fact that utilizing the VS Code API in a Webview isn't as straight forward as The Webview for the Bruno Panel seems to work by trying to load the extension script as a regular JS script in the Webview's HTML for code reuse; this won't work for a variety of reasons. Firstly, the above-mentioned inability to access the Related, Webpack 5 doesn't do automatic Node.js polyfills anymore, so I used this to get me as far as I could: https://webpack.js.org/configuration/resolve/#resolvefallback. I'm not a JS developer, so I hit the limits of what I was able to pull off, and I also unfortunately forgot to push my changes up to a fork, and deleted my local clone. That was a very dumb move on my part. But I doubt my changes were the proper solution, anyway. But point is, it seems that the extension needs a very deep refactor to fix these issues. Extra Unsolicted InputI'd advocate for changing the Webpack target from |
I'm facing the error described in "Run request" and Bruno Panel not loading on VS Code 1.80. I hope somebody can help with the fixes because it would be helpful to use this extension within VSC. Unfortunately I'm not expert in JavaScript programming and development of VSC extensions, otherwise I'd be happy to help. Thanks @dljsjr for opening this issue and analysing what's going wrong. |
This is the root cause of:
It's pretty easy to verify by inspecting the output from
vsce
's various commands.The text was updated successfully, but these errors were encountered: