You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update @urql/core with above types (with modifications?)
We probably don't want to support the old format, since it was experimental. Instead, I'd flag this as a minor with a note in the changelog that reflects why we've done this.
Update mergeResultPatch to reflect the new format:
We must be able to comply with the new format in full; again, label is treated as optional and we don't currently use its information
We should look into how extensions and errors are now treated, since there could be multiple ones sent per response.
We should check what happens to result.extensions and result.errors if those can also be present on result.incremental[].extensions and result.incremental[].errors now
The text was updated successfully, but these errors were encountered:
kitten
added
the
future 🔮
An enhancement or feature proposal that will be addressed after the next release
label
Mar 6, 2023
This RFC supersedes #2995.
Summary
See spec edits for incremental delivery support in
graphql-spec
: https://github.com/graphql/graphql-spec/pull/742/files#diff-98d0cd153b72b63c417ad4238e8cc0d3385691ccbde7f7674bc0d2a718b896ecSee updated implementation of graphql-js: graphql/graphql-js#3659
Previously, our current definition of
ExecutionResult
looks like the following:urql/packages/core/src/types.ts
Lines 21 to 37 in 9ecfba4
The spec has been updated to instead look like the following for incremental responses:
Proposed Solution
@urql/core
with above types (with modifications?)minor
with a note in the changelog that reflects why we've done this.mergeResultPatch
to reflect the new format:urql/packages/core/src/utils/result.ts
Lines 28 to 32 in 9ecfba4
Requirements
label
is treated as optional and we don't currently use its informationextensions
anderrors
are now treated, since there could be multiple ones sent per response.result.extensions
andresult.errors
if those can also be present onresult.incremental[].extensions
andresult.incremental[].errors
nowThe text was updated successfully, but these errors were encountered: