Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement context.Context #839

Closed
marwan-at-work opened this issue Aug 5, 2019 · 1 comment
Closed

implement context.Context #839

marwan-at-work opened this issue Aug 5, 2019 · 1 comment
Assignees
@marwan-at-work
Labels
kind/feature describes a code enhancement / feature request status/claimed someone has claimed this issue

Comments

@marwan-at-work
Copy link
Contributor

*cli.Context should implement context.Context and tie the context cancellation (Done()) to a user hitting ctrl+C
@marwan-at-work marwan-at-work mentioned this issue Aug 5, 2019
Merged
@coilysiren coilysiren added status/claimed someone has claimed this issue kind/feature describes a code enhancement / feature request labels Aug 6, 2019
@coilysiren
Copy link
Member

✔️ #840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marwan-at-work marwan-at-work

Labels
kind/feature describes a code enhancement / feature request status/claimed someone has claimed this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coilysiren @marwan-at-work