New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out what's wrong with path parsing #122

Open

arduano opened this issue Apr 29, 2024 · 1 comment

Collaborator

arduano commented Apr 29, 2024

These 2 test cases:

        assert_eq!(
            eval_ok("builtins.baseNameOf /foo/bar/baz/"),
            Value::Str("baz".into())
        );
        assert_eq!(
            eval_ok("(builtins.baseNameOf (/foo/bar/baz/))"),
            Value::Str("baz".into())
        );

Produce some very weird/unexpected results, including a panic on the second one.

Collaborator Author

arduano commented Apr 29, 2024

In theory, paths cant have trailing slashes in the first place, and it should throw a parser error there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment