Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when using unplugin-vue/esbuild, an error will occur if there is no dependency on Vite. #155

Closed
5 tasks done
zzfn opened this issue Mar 9, 2024 · 6 comments
Closed
5 tasks done

Comments

@zzfn
Copy link

zzfn commented Mar 9, 2024

Describe the bug

CleanShot 2024-03-10 at 00 44 01@2x

Reproduction

https://github.com/element-plus/element-plus-icons.git

System Info

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 79.22 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - /opt/homebrew/opt/node@20/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 10.2.3 - /opt/homebrew/opt/node@20/bin/npm
    pnpm: 8.15.4 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 122.0.6261.112
    Chrome Canary: 124.0.6347.0
    Edge: 122.0.2365.80
    Safari: 16.5.1

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@sxzz
Copy link
Member

sxzz commented Mar 9, 2024

Cannot reproduce. Try to remove node_modules and re-install again.

@sxzz
Copy link
Member

sxzz commented Mar 9, 2024

@sxzz sxzz closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2024
@zzfn
Copy link
Author

zzfn commented Mar 9, 2024

i'm sorry, I didn't make it clear
i encountered this issue while using esbuild separately.
the steps to reproduce can deleting the "playground" folder.
i thinking is that vite, a dependency of "playground" is being detected, which is why no errors are being reported.
@sxzz

@sxzz
Copy link
Member

sxzz commented Mar 9, 2024

Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required

@zzfn
Copy link
Author

zzfn commented Mar 9, 2024

Please provide a minimal reproduction to reopen the issue. Thanks.

Why reproduction is required

it is reproduction (github issue only the comment button)

@sxzz sxzz reopened this Mar 9, 2024
@sxzz sxzz closed this as completed in 74f4ac7 Mar 9, 2024
@sxzz
Copy link
Member

sxzz commented Mar 9, 2024

Thanks for your feedback! Fixed & Released as 5.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants