Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templated TabBarITem IsSelectable doesn't work correctly #1256

Closed
17 tasks
iurycarlos opened this issue Sep 24, 2024 · 1 comment · Fixed by #1261
Closed
17 tasks

Templated TabBarITem IsSelectable doesn't work correctly #1256

iurycarlos opened this issue Sep 24, 2024 · 1 comment · Fixed by #1261
Assignees
@Darsh0307 @jhanvi03
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@iurycarlos
Copy link
Contributor

Current behavior

When using DataTemplate for TabBarItem, the element's behavior wont reflect the IsSelectable value.

Expected behavior

It should work normally. IsSelectable / IsEnabled should prevent user to select the TabBarItem.

How to reproduce it

Just use this repro and compare the TabBars.

TabBarTemplateTest.zip

Nuget Package:

https://www.nuget.org/packages/Uno.Sdk/5.5.0-dev.53

Package Version(s):

Affected platform(s):

  • WebAssembly
  • Android
  • iOS
  • macOS (AppKit)
  • Mac Catalyst
  • Skia
    • WPF
    • GTK (Linux)
    • Linux Framebuffer
    • Tizen
  • Windows

IDE:

  • Visual Studio 2022
  • Visual Studio 2019
  • Visual Studio Code
  • Visual Studio for Mac
  • Rider Windows
  • Rider macOS

Relevant plugins:

Anything else we need to know?
@iurycarlos iurycarlos added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Sep 24, 2024
@iurycarlos iurycarlos mentioned this issue Sep 24, 2024
Closed
@eriklimakc eriklimakc mentioned this issue Oct 9, 2024
Merged
18 tasks
@kazo0 kazo0 linked a pull request Oct 14, 2024 that will close this issue
fix: Use proper container for TabBar ItemTemplate #1261
Merged
18 tasks
@mergify mergify bot mentioned this issue Oct 16, 2024
Merged
18 tasks
@agneszitte agneszitte assigned jhanvi03 and unassigned eriklimakc Oct 22, 2024
@jhanvi03
Copy link

@Darsh0307 Can you please verify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Darsh0307 Darsh0307

@jhanvi03 jhanvi03

Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use proper container for TabBar ItemTemplate unoplatform/uno.toolkit.ui
4 participants
@iurycarlos @Darsh0307 @eriklimakc @jhanvi03