Make sure we are not missing splash screen xml file in AndroidResource

[Youssef1313]

I'm not too sure, but we might be missing including uno_splash_image.xml in AndroidResource

[Youssef1313]

@pictos Can you please confirm if I'm correct?

[pictos]

@Youssef1313 it's included at some point because the app can run sometimes, so it's something related to the incremental builds. The fix on Xamarin.Android repo, that you mention in another issue isn't released yet, so maybe we have to wait for it?

[Youssef1313]

This is not about the build issue (currently Jerome is looking into it), but I found the only place we include an android resource is:

uno.resizetizer/src/.nuspec/Uno.Resizetizer.targets

Lines 544 to 546 in a394b82

	<AndroidResource Include="@(_ResizetizerCollectedAppIcons)"
	Link="%(_ResizetizerCollectedAppIcons.RecursiveDir)%(_ResizetizerCollectedAppIcons.Filename)%(_ResizetizerCollectedAppIcons.Extension)" >
	</AndroidResource>

I think this doesn't include uno_splash_image.xml, so was wondering how it is included (if at all), and whether this can cause issues.

cc @jeromelaban as well for thoughts.

[pictos]

@Youssef1313 the splash screen are handled in another task, here's where the splash assets are generated

uno.resizetizer/src/.nuspec/Uno.Resizetizer.targets

Lines 386 to 397 in a394b82

	<GenerateSplashAndroidResources_v0
	Condition="'$(_ResizetizerIsAndroidApp)' == 'True'"
	IntermediateOutputPath="$(_UnoIntermediateSplashScreen)"
	UnoSplashScreen="@(UnoSplashScreen)"
	/>
	<ItemGroup Condition="'$(_ResizetizerIsAndroidApp)' == 'True'">
	<UnoImage Include="@(UnoSplashScreen)" />
	<LibraryResourceDirectories Condition="Exists('$(_UnoIntermediateSplashScreen)')" Include="$(_UnoIntermediateSplashScreen)">
	<StampFile>$(_ResizetizerStampFile)</StampFile>
	</LibraryResourceDirectories>
	<FileWrites Include="$(_UnoIntermediateSplashScreen)**\*" />
	</ItemGroup>

[Youssef1313]

@pictos Yes I see it's generated here, but not added to AndroidResource after generated. So trying to understand why it's not added or if it's added somewhere I can't see.

[pictos]

@Youssef1313 we added the generated assets as LibraryResourceDirectories, that's handled by Xamarin.Android build tasks in the pipeline, you can check that on binlog

[nickrandolph]

@Youssef1313 is this a derived issue or duplicate of #106?

[Youssef1313]

@Youssef1313 we added the generated assets as LibraryResourceDirectories, that's handled by Xamarin.Android build tasks in the pipeline, you can check that on binlog

Good, just wanted to make sure we are not missing it. Let me close then.

[Youssef1313]

@Youssef1313 is this a derived issue or duplicate of #106?

Nope.