From efe66899a2fa4db567e4623d53ac054053ea4aec Mon Sep 17 00:00:00 2001
From: David <github.site@torick.net>
Date: Mon, 7 Nov 2022 09:41:22 -0500
Subject: [PATCH 1/2] chore: Ensure building delegates are static

---
 src/Uno.Extensions.Reactive/Core/Feed.T.cs    | 16 ++++----
 src/Uno.Extensions.Reactive/Core/Feed.cs      |  6 +--
 .../Core/ListFeed.T.cs                        |  4 +-
 src/Uno.Extensions.Reactive/Core/ListFeed.cs  |  2 +-
 src/Uno.Extensions.Reactive/Core/State.T.cs   | 38 +++++++++----------
 5 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/src/Uno.Extensions.Reactive/Core/Feed.T.cs b/src/Uno.Extensions.Reactive/Core/Feed.T.cs
index 7535c62395..ab78dddd8d 100644
--- a/src/Uno.Extensions.Reactive/Core/Feed.T.cs
+++ b/src/Uno.Extensions.Reactive/Core/Feed.T.cs
@@ -19,7 +19,7 @@ public static class Feed<T> // We set the T on the class to it greatly helps typ
 	/// <param name="sourceProvider">The provider of the message enumerable sequence.</param>
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IFeed<T> Create(Func<CancellationToken, IAsyncEnumerable<Message<T>>> sourceProvider)
-		=> AttachedProperty.GetOrCreate(sourceProvider, sp => new CustomFeed<T>(sp));
+		=> AttachedProperty.GetOrCreate(sourceProvider, static sp => new CustomFeed<T>(sp));
 
 	/// <summary>
 	/// Gets or create a custom feed from a raw <see cref="IAsyncEnumerable{T}"/> sequence of <see cref="Message{T}"/>.
@@ -27,7 +27,7 @@ public static IFeed<T> Create(Func<CancellationToken, IAsyncEnumerable<Message<T
 	/// <param name="sourceProvider">The provider of the message enumerable sequence.</param>
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IFeed<T> Create(Func<IAsyncEnumerable<Message<T>>> sourceProvider)
-		=> AttachedProperty.GetOrCreate(sourceProvider, sp => new CustomFeed<T>(_ => sp()));
+		=> AttachedProperty.GetOrCreate(sourceProvider, static sp => new CustomFeed<T>(_ => sp()));
 
 	/// <summary>
 	/// Gets or create a custom feed from an async method.
@@ -38,7 +38,7 @@ public static IFeed<T> Create(Func<IAsyncEnumerable<Message<T>>> sourceProvider)
 	public static IFeed<T> Async(AsyncFunc<Option<T>> valueProvider, Signal? refresh = null)
 		=> refresh is null
 			? AttachedProperty.GetOrCreate(valueProvider, vp => new AsyncFeed<T>(vp))
-			: AttachedProperty.GetOrCreate(refresh, valueProvider, (r, vp) => new AsyncFeed<T>(vp, r));
+			: AttachedProperty.GetOrCreate(refresh, valueProvider, static (r, vp) => new AsyncFeed<T>(vp, r));
 
 	/// <summary>
 	/// Gets or create a custom feed from an async method.
@@ -49,7 +49,7 @@ public static IFeed<T> Async(AsyncFunc<Option<T>> valueProvider, Signal? refresh
 	public static IFeed<T> Async(AsyncFunc<T> valueProvider, Signal? refresh = null)
 		=> refresh is null
 			? AttachedProperty.GetOrCreate(valueProvider, vp => new AsyncFeed<T>(vp))
-			: AttachedProperty.GetOrCreate(refresh, valueProvider, (r, vp) => new AsyncFeed<T>(vp, r));
+			: AttachedProperty.GetOrCreate(refresh, valueProvider, static (r, vp) => new AsyncFeed<T>(vp, r));
 
 	/// <summary>
 	/// Gets or create a custom feed from an async enumerable sequence of value.
@@ -57,7 +57,7 @@ public static IFeed<T> Async(AsyncFunc<T> valueProvider, Signal? refresh = null)
 	/// <param name="enumerableProvider">The async enumerable sequence of value of the resulting feed.</param>
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IFeed<T> AsyncEnumerable(Func<IAsyncEnumerable<Option<T>>> enumerableProvider)
-		=> AttachedProperty.GetOrCreate(enumerableProvider, ep => new AsyncEnumerableFeed<T>(ep));
+		=> AttachedProperty.GetOrCreate(enumerableProvider, static ep => new AsyncEnumerableFeed<T>(ep));
 
 	/// <summary>
 	/// Gets or create a custom feed from an async enumerable sequence of value.
@@ -65,7 +65,7 @@ public static IFeed<T> AsyncEnumerable(Func<IAsyncEnumerable<Option<T>>> enumera
 	/// <param name="enumerableProvider">The async enumerable sequence of value of the resulting feed.</param>
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IFeed<T> AsyncEnumerable(Func<CancellationToken, IAsyncEnumerable<Option<T>>> enumerableProvider)
-		=> AttachedProperty.GetOrCreate(enumerableProvider, ep => new AsyncEnumerableFeed<T>(ep));
+		=> AttachedProperty.GetOrCreate(enumerableProvider, static ep => new AsyncEnumerableFeed<T>(ep));
 
 	/// <summary>
 	/// Gets or create a custom feed from an async enumerable sequence of value.
@@ -73,7 +73,7 @@ public static IFeed<T> AsyncEnumerable(Func<CancellationToken, IAsyncEnumerable<
 	/// <param name="enumerableProvider">The async enumerable sequence of value of the resulting feed.</param>
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IFeed<T> AsyncEnumerable(Func<IAsyncEnumerable<T>> enumerableProvider)
-		=> AttachedProperty.GetOrCreate(enumerableProvider, ep => new AsyncEnumerableFeed<T>(ep));
+		=> AttachedProperty.GetOrCreate(enumerableProvider, static ep => new AsyncEnumerableFeed<T>(ep));
 
 	/// <summary>
 	/// Gets or create a custom feed from an async enumerable sequence of value.
@@ -81,5 +81,5 @@ public static IFeed<T> AsyncEnumerable(Func<IAsyncEnumerable<T>> enumerableProvi
 	/// <param name="enumerableProvider">The async enumerable sequence of value of the resulting feed.</param>
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IFeed<T> AsyncEnumerable(Func<CancellationToken, IAsyncEnumerable<T>> enumerableProvider)
-		=> AttachedProperty.GetOrCreate(enumerableProvider, ep => new AsyncEnumerableFeed<T>(ep));
+		=> AttachedProperty.GetOrCreate(enumerableProvider, static ep => new AsyncEnumerableFeed<T>(ep));
 }
diff --git a/src/Uno.Extensions.Reactive/Core/Feed.cs b/src/Uno.Extensions.Reactive/Core/Feed.cs
index 8c753b1a5c..4ae9afc71a 100644
--- a/src/Uno.Extensions.Reactive/Core/Feed.cs
+++ b/src/Uno.Extensions.Reactive/Core/Feed.cs
@@ -65,7 +65,7 @@ public static IFeed<T> AsyncEnumerable<T>(Func<CancellationToken, IAsyncEnumerab
 	public static IFeed<TSource> Where<TSource>(
 		this IFeed<TSource> source,
 		Predicate<TSource> predicate)
-		=> AttachedProperty.GetOrCreate(source, predicate, (src, p) => new WhereFeed<TSource>(src, p));
+		=> AttachedProperty.GetOrCreate(source, predicate, static (src, p) => new WhereFeed<TSource>(src, p));
 
 	/// <summary>
 	/// Gets or create a feed that projects each value of a source feed.
@@ -78,7 +78,7 @@ public static IFeed<TSource> Where<TSource>(
 	public static IFeed<TResult> Select<TSource, TResult>(
 		this IFeed<TSource> source,
 		Func<TSource, TResult> selector)
-		=> AttachedProperty.GetOrCreate(source, selector, (src, s) => new SelectFeed<TSource, TResult>(src, s));
+		=> AttachedProperty.GetOrCreate(source, selector, static (src, s) => new SelectFeed<TSource, TResult>(src, s));
 
 	/// <summary>
 	/// Gets or create a feed that asynchronously projects each value of a source feed.
@@ -91,6 +91,6 @@ public static IFeed<TResult> Select<TSource, TResult>(
 	public static IFeed<TResult> SelectAsync<TSource, TResult>(
 		this IFeed<TSource> source,
 		AsyncFunc<TSource, TResult> selector)
-		=> AttachedProperty.GetOrCreate(source, selector, (src, s) => new SelectAsyncFeed<TSource, TResult>(src, s));
+		=> AttachedProperty.GetOrCreate(source, selector, static (src, s) => new SelectAsyncFeed<TSource, TResult>(src, s));
 	#endregion
 }
diff --git a/src/Uno.Extensions.Reactive/Core/ListFeed.T.cs b/src/Uno.Extensions.Reactive/Core/ListFeed.T.cs
index fc1c29423f..5cbea47279 100644
--- a/src/Uno.Extensions.Reactive/Core/ListFeed.T.cs
+++ b/src/Uno.Extensions.Reactive/Core/ListFeed.T.cs
@@ -74,7 +74,7 @@ public static IListFeed<T> AsyncEnumerable(Func<IAsyncEnumerable<IImmutableList<
 	/// <param name="getPage">The async method to load a page of items.</param>
 	/// <returns>A paginated list feed.</returns>
 	public static IListFeed<T> AsyncPaginatedByCursor<TCursor>(TCursor firstPage, GetPage<TCursor, T> getPage)
-		=> AttachedProperty.GetOrCreate(getPage.Target ?? getPage.Method, (firstPage, getPage), (_, args) => new PaginatedListFeed<TCursor,T>(args.firstPage, args.getPage));
+		=> AttachedProperty.GetOrCreate(getPage.Target ?? getPage.Method, (firstPage, getPage), static (_, args) => new PaginatedListFeed<TCursor,T>(args.firstPage, args.getPage));
 
 	/// <summary>
 	/// Creates a list feed for a paginated collection.
@@ -82,5 +82,5 @@ public static IListFeed<T> AsyncPaginatedByCursor<TCursor>(TCursor firstPage, Ge
 	/// <param name="getPage">The async method to load a page of items.</param>
 	/// <returns>A paginated list feed.</returns>
 	public static IListFeed<T> AsyncPaginated(AsyncFunc<PageRequest, IImmutableList<T>> getPage)
-		=> AttachedProperty.GetOrCreate(getPage, gp => new PaginatedListFeed<ByIndexCursor<T>, T>(ByIndexCursor<T>.First, ByIndexCursor<T>.GetPage(gp)));
+		=> AttachedProperty.GetOrCreate(getPage, static gp => new PaginatedListFeed<ByIndexCursor<T>, T>(ByIndexCursor<T>.First, ByIndexCursor<T>.GetPage(gp)));
 }
diff --git a/src/Uno.Extensions.Reactive/Core/ListFeed.cs b/src/Uno.Extensions.Reactive/Core/ListFeed.cs
index c5f0b0bfa9..49f722312f 100644
--- a/src/Uno.Extensions.Reactive/Core/ListFeed.cs
+++ b/src/Uno.Extensions.Reactive/Core/ListFeed.cs
@@ -81,7 +81,7 @@ public static IListFeed<T> AsyncPaginated<T>(AsyncFunc<PageRequest, IImmutableLi
 	public static IListFeed<TSource> Where<TSource>(
 		this IListFeed<TSource> source,
 		Predicate<TSource> predicate)
-		=> AttachedProperty.GetOrCreate(source, predicate, (src, p) => new WhereListFeed<TSource>(src, p));
+		=> AttachedProperty.GetOrCreate(source, predicate, static (src, p) => new WhereListFeed<TSource>(src, p));
 
 	//public static IListFeed<TResult> Select<TSource, TResult>(
 	//	this IListFeed<TSource> source,
diff --git a/src/Uno.Extensions.Reactive/Core/State.T.cs b/src/Uno.Extensions.Reactive/Core/State.T.cs
index 7cc35beeec..347ff83a2d 100644
--- a/src/Uno.Extensions.Reactive/Core/State.T.cs
+++ b/src/Uno.Extensions.Reactive/Core/State.T.cs
@@ -25,7 +25,7 @@ public static partial class State<T>
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> Create<TOwner>(TOwner owner, Func<CancellationToken, IAsyncEnumerable<Message<T>>> sourceProvider)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, sourceProvider, (o, sp) => S(o, new CustomFeed<T>(sp)));
+		=> AttachedProperty.GetOrCreate(owner, sourceProvider, static (o, sp) => S(o, new CustomFeed<T>(sp)));
 
 	/// <summary>
 	/// Creates a custom feed from a raw <see cref="IAsyncEnumerable{T}"/> sequence of <see cref="Message{T}"/>.
@@ -34,7 +34,7 @@ public static IState<T> Create<TOwner>(TOwner owner, Func<CancellationToken, IAs
 	/// <returns>A feed that encapsulate the source.</returns>
 	[EditorBrowsable(EditorBrowsableState.Never)]
 	internal static IState<T> Create(Func<CancellationToken, IAsyncEnumerable<Message<T>>> sourceProvider)
-		=> AttachedProperty.GetOrCreate(Validate(sourceProvider), sp => S(sp, new CustomFeed<T>(sp)));
+		=> AttachedProperty.GetOrCreate(Validate(sourceProvider), static sp => S(sp, new CustomFeed<T>(sp)));
 
 	/// <summary>
 	/// Creates a custom feed from a raw <see cref="IAsyncEnumerable{T}"/> sequence of <see cref="Message{T}"/>.
@@ -45,7 +45,7 @@ internal static IState<T> Create(Func<CancellationToken, IAsyncEnumerable<Messag
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> Create<TOwner>(TOwner owner, Func<IAsyncEnumerable<Message<T>>> sourceProvider)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, sourceProvider, (o, sp) => S(o, new CustomFeed<T>(_ => sp())));
+		=> AttachedProperty.GetOrCreate(owner, sourceProvider, static (o, sp) => S(o, new CustomFeed<T>(_ => sp())));
 
 	/// <summary>
 	/// Creates a custom feed from a raw <see cref="IAsyncEnumerable{T}"/> sequence of <see cref="Message{T}"/>.
@@ -54,7 +54,7 @@ public static IState<T> Create<TOwner>(TOwner owner, Func<IAsyncEnumerable<Messa
 	/// <returns>A feed that encapsulate the source.</returns>
 	[EditorBrowsable(EditorBrowsableState.Never)]
 	internal static IState<T> Create(Func<IAsyncEnumerable<Message<T>>> sourceProvider)
-		=> AttachedProperty.GetOrCreate(Validate(sourceProvider), sp => S(sp, new CustomFeed<T>(_ => sp())));
+		=> AttachedProperty.GetOrCreate(Validate(sourceProvider), static sp => S(sp, new CustomFeed<T>(_ => sp())));
 
 	/// <summary>
 	/// Gets or creates an empty state.
@@ -72,7 +72,7 @@ public static IState<T> Empty<TOwner>(TOwner owner, [CallerMemberName] string? n
 				name ?? throw new InvalidOperationException("The name of the state must not be null"),
 				line <0 ? throw new InvalidOperationException("The provided line number is invalid.") : line
 			),
-			(o, _) => SourceContext.GetOrCreate(o).CreateState(Option<T>.None()));
+			static (o, _) => SourceContext.GetOrCreate(o).CreateState(Option<T>.None()));
 
 	/// <summary>
 	/// Gets or creates a state from a static initial value.
@@ -84,7 +84,7 @@ public static IState<T> Empty<TOwner>(TOwner owner, [CallerMemberName] string? n
 	public static IState<T> Value<TOwner>(TOwner owner, Func<T> valueProvider)
 		where TOwner : class
 		// Note: We force the usage of delegate so 2 properties which are doing State.Value(this, () => 42) will effectively have 2 distinct states.
-		=> AttachedProperty.GetOrCreate(owner, valueProvider, (o, v) => SourceContext.GetOrCreate(o).CreateState(Option<T>.Some(v())));
+		=> AttachedProperty.GetOrCreate(owner, valueProvider, static (o, v) => SourceContext.GetOrCreate(o).CreateState(Option<T>.Some(v())));
 
 	/// <summary>
 	/// Gets or creates a state from a static initial value.
@@ -96,7 +96,7 @@ public static IState<T> Value<TOwner>(TOwner owner, Func<T> valueProvider)
 	public static IState<T> Value<TOwner>(TOwner owner, Func<Option<T>> valueProvider)
 		where TOwner : class
 		// Note: We force the usage of delegate so 2 properties which are doing State.Value(this, () => 42) will effectively have 2 distinct states.
-		=> AttachedProperty.GetOrCreate(owner, valueProvider, (o, v) => SourceContext.GetOrCreate(owner).CreateState(v()));
+		=> AttachedProperty.GetOrCreate(owner, valueProvider, static (o, v) => SourceContext.GetOrCreate(o).CreateState(v()));
 
 	/// <summary>
 	/// Gets or creates a state from an async method.
@@ -108,7 +108,7 @@ public static IState<T> Value<TOwner>(TOwner owner, Func<Option<T>> valueProvide
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> Async<TOwner>(TOwner owner, AsyncFunc<Option<T>> valueProvider, Signal? refresh = null)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, (valueProvider, refresh), (o, args) => S(o, new AsyncFeed<T>(args.valueProvider, args.refresh)));
+		=> AttachedProperty.GetOrCreate(owner, (valueProvider, refresh), static (o, args) => S(o, new AsyncFeed<T>(args.valueProvider, args.refresh)));
 
 	/// <summary>
 	/// Gets or creates a state from an async method.
@@ -120,7 +120,7 @@ public static IState<T> Async<TOwner>(TOwner owner, AsyncFunc<Option<T>> valuePr
 	internal static IState<T> Async(AsyncFunc<Option<T>> valueProvider, Signal? refresh = null)
 		=> refresh is null
 			? AttachedProperty.GetOrCreate(Validate(valueProvider), vp => S(vp, new AsyncFeed<T>(vp)))
-			: AttachedProperty.GetOrCreate(refresh, Validate(valueProvider), (r, vp) => S(vp, new AsyncFeed<T>(vp, r)));
+			: AttachedProperty.GetOrCreate(refresh, Validate(valueProvider), static (r, vp) => S(vp, new AsyncFeed<T>(vp, r)));
 
 	/// <summary>
 	/// Gets or creates a state from an async method.
@@ -132,7 +132,7 @@ internal static IState<T> Async(AsyncFunc<Option<T>> valueProvider, Signal? refr
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> Async<TOwner>(TOwner owner, AsyncFunc<T> valueProvider, Signal? refresh = null)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, (valueProvider, refresh), (o, args) => S(o, new AsyncFeed<T>(args.valueProvider, args.refresh)));
+		=> AttachedProperty.GetOrCreate(owner, (valueProvider, refresh), static (o, args) => S(o, new AsyncFeed<T>(args.valueProvider, args.refresh)));
 
 	/// <summary>
 	/// Gets or creates a state from an async method.
@@ -143,8 +143,8 @@ public static IState<T> Async<TOwner>(TOwner owner, AsyncFunc<T> valueProvider,
 	[EditorBrowsable(EditorBrowsableState.Never)]
 	internal static IState<T> Async(AsyncFunc<T> valueProvider, Signal? refresh = null)
 		=> refresh is null
-			? AttachedProperty.GetOrCreate(Validate(valueProvider), vp => S(vp, new AsyncFeed<T>(vp)))
-			: AttachedProperty.GetOrCreate(refresh, Validate(valueProvider), (r, vp) => S(vp, new AsyncFeed<T>(vp, r)));
+			? AttachedProperty.GetOrCreate(Validate(valueProvider), static vp => S(vp, new AsyncFeed<T>(vp)))
+			: AttachedProperty.GetOrCreate(refresh, Validate(valueProvider), static (r, vp) => S(vp, new AsyncFeed<T>(vp, r)));
 
 	/// <summary>
 	/// Gets or creates a state from an async enumerable sequence of value.
@@ -155,7 +155,7 @@ internal static IState<T> Async(AsyncFunc<T> valueProvider, Signal? refresh = nu
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> AsyncEnumerable<TOwner>(TOwner owner, Func<IAsyncEnumerable<Option<T>>> enumerableProvider)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, enumerableProvider, (o, ep) => S(o, new AsyncEnumerableFeed<T>(ep)));
+		=> AttachedProperty.GetOrCreate(owner, enumerableProvider, static (o, ep) => S(o, new AsyncEnumerableFeed<T>(ep)));
 
 	/// <summary>
 	/// Gets or creates a state from an async enumerable sequence of value.
@@ -166,7 +166,7 @@ public static IState<T> AsyncEnumerable<TOwner>(TOwner owner, Func<IAsyncEnumera
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> AsyncEnumerable<TOwner>(TOwner owner, Func<CancellationToken, IAsyncEnumerable<Option<T>>> enumerableProvider)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, enumerableProvider, (o, ep) => S(o, new AsyncEnumerableFeed<T>(ep)));
+		=> AttachedProperty.GetOrCreate(owner, enumerableProvider, static (o, ep) => S(o, new AsyncEnumerableFeed<T>(ep)));
 
 	/// <summary>
 	/// Gets or creates a state from an async enumerable sequence of value.
@@ -175,7 +175,7 @@ public static IState<T> AsyncEnumerable<TOwner>(TOwner owner, Func<CancellationT
 	/// <returns>A feed that encapsulate the source.</returns>
 	[EditorBrowsable(EditorBrowsableState.Never)]
 	internal static IState<T> AsyncEnumerable(Func<IAsyncEnumerable<Option<T>>> enumerableProvider)
-		=> AttachedProperty.GetOrCreate(Validate(enumerableProvider), ep => S(ep, new AsyncEnumerableFeed<T>(ep)));
+		=> AttachedProperty.GetOrCreate(Validate(enumerableProvider), static ep => S(ep, new AsyncEnumerableFeed<T>(ep)));
 
 	/// <summary>
 	/// Gets or creates a state from an async enumerable sequence of value.
@@ -186,7 +186,7 @@ internal static IState<T> AsyncEnumerable(Func<IAsyncEnumerable<Option<T>>> enum
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> AsyncEnumerable<TOwner>(TOwner owner, Func<IAsyncEnumerable<T>> enumerableProvider)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, enumerableProvider, (o, ep) => S(o, new AsyncEnumerableFeed<T>(ep)));
+		=> AttachedProperty.GetOrCreate(owner, enumerableProvider, static (o, ep) => S(o, new AsyncEnumerableFeed<T>(ep)));
 
 	/// <summary>
 	/// Gets or creates a state from an async enumerable sequence of value.
@@ -197,7 +197,7 @@ public static IState<T> AsyncEnumerable<TOwner>(TOwner owner, Func<IAsyncEnumera
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> AsyncEnumerable<TOwner>(TOwner owner, Func<CancellationToken, IAsyncEnumerable<T>> enumerableProvider)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, enumerableProvider, (o, ep) => S(o, new AsyncEnumerableFeed<T>(ep)));
+		=> AttachedProperty.GetOrCreate(owner, enumerableProvider, static (o, ep) => S(o, new AsyncEnumerableFeed<T>(ep)));
 
 	/// <summary>
 	/// Gets or creates a state from an async enumerable sequence of value.
@@ -206,7 +206,7 @@ public static IState<T> AsyncEnumerable<TOwner>(TOwner owner, Func<CancellationT
 	/// <returns>A feed that encapsulate the source.</returns>
 	[EditorBrowsable(EditorBrowsableState.Never)]
 	internal static IState<T> AsyncEnumerable(Func<IAsyncEnumerable<T>> enumerableProvider)
-		=> AttachedProperty.GetOrCreate(Validate(enumerableProvider), ep => S(ep, new AsyncEnumerableFeed<T>(ep)));
+		=> AttachedProperty.GetOrCreate(Validate(enumerableProvider), static ep => S(ep, new AsyncEnumerableFeed<T>(ep)));
 
 	/// <summary>
 	/// Gets or creates a state from an async enumerable sequence of value.
@@ -217,7 +217,7 @@ internal static IState<T> AsyncEnumerable(Func<IAsyncEnumerable<T>> enumerablePr
 	/// <returns>A feed that encapsulate the source.</returns>
 	public static IState<T> FromFeed<TOwner>(TOwner owner, IFeed<T> feed)
 		where TOwner : class
-		=> AttachedProperty.GetOrCreate(owner, feed, (o, f) => S(o, f));
+		=> AttachedProperty.GetOrCreate(owner, feed, static (o, f) => S(o, f));
 
 	private static TKey Validate<TKey>(TKey key, [CallerMemberName] string? caller = null)
 		where TKey : Delegate

From 0d045fa4945bb6fac326d6f25765f9b8ef713e67 Mon Sep 17 00:00:00 2001
From: David <github.site@torick.net>
Date: Mon, 7 Nov 2022 10:15:08 -0500
Subject: [PATCH 2/2] docs: Add doc on Option

---
 src/Uno.Extensions.Core/Option.T.cs   | 58 +++++++++++++++++++++++++++
 src/Uno.Extensions.Core/OptionType.cs | 16 ++++++--
 2 files changed, 71 insertions(+), 3 deletions(-)

diff --git a/src/Uno.Extensions.Core/Option.T.cs b/src/Uno.Extensions.Core/Option.T.cs
index 2b505b1be5..4a2db72237 100644
--- a/src/Uno.Extensions.Core/Option.T.cs
+++ b/src/Uno.Extensions.Core/Option.T.cs
@@ -5,14 +5,31 @@
 
 namespace Uno.Extensions;
 
+/// <summary>
+/// A wrapper over a optional value that describes its absence or presence.
+/// </summary>
+/// <typeparam name="T">The type of the value</typeparam>
 public readonly struct Option<T> : IOption, IEquatable<Option<T>>
 {
+	/// <summary>
+	/// Creates a new optional value that is flagged as present.
+	/// </summary>
+	/// <param name="value">The value.</param>
+	/// <returns>The optional value.</returns>
 	public static Option<T> Some(T value)
 		=> new(OptionType.Some, value);
 
+	/// <summary>
+	/// Creates a new optional value that is flagged as absent.
+	/// </summary>
+	/// <returns>The optional value.</returns>
 	public static Option<T> None()
 		=> default;
 
+	/// <summary>
+	/// Creates a new optional value that is flagged as neither present nor absent.
+	/// </summary>
+	/// <returns>The optional value.</returns>
 	public static Option<T> Undefined()
 		=> new(OptionType.Undefined);
 
@@ -25,40 +42,73 @@ internal Option(OptionType type, T? value = default)
 		_value = value;
 	}
 
+	/// <summary>
+	/// Gets the type of this optional value.
+	/// </summary>
 	public OptionType Type => _type;
 
+	/// <summary>
+	/// Gets a boolean that indicates if the <see cref="Type"/> of this optional is <see cref="OptionType.Undefined"/>.
+	/// </summary>
 	public bool IsUndefined()
 		=> _type is OptionType.Undefined;
 
+	/// <summary>
+	/// Gets a boolean that indicates if the <see cref="Type"/> of this optional is <see cref="OptionType.None"/>.
+	/// </summary>
 	public bool IsNone()
 		=> _type is OptionType.None;
 
+	/// <summary>
+	/// Gets a boolean that indicates if the <see cref="Type"/> of this optional is <see cref="OptionType.Some"/>.
+	/// </summary>
+	/// <param name="value">The value is any.</param>
 	public bool IsSome([NotNullWhen(true)] out T value)
 	{
 		value = _value!;
 		return _type is OptionType.Some;
 	}
 
+	/// <inheritdoc />
 	bool IOption.IsSome(out object? value)
 	{
 		value = _value;
 		return _type is OptionType.Some;
 	}
 
+	/// <summary>
+	/// Gets the value if <see cref="Type"/> is <seealso cref="OptionType.Some"/>, other returns the default(<typeparamref name="T"/>).
+	/// </summary>
+	/// <returns>The value if Some, default(T) otherwise.</returns>
 	public T? SomeOrDefault()
 		=> _value;
 
+	/// <inheritdoc />
 	object? IOption.SomeOrDefault()
 		=> _value;
 
+	/// <summary>
+	/// Gets the value if <see cref="Type"/> is <seealso cref="OptionType.Some"/>, other returns the <paramref name="defaultValue"/>.
+	/// </summary>
+	/// <param name="defaultValue">The default value to return is this optional value is not present.</param>
+	/// <returns>The value if Some, <paramref name="defaultValue"/> otherwise.</returns>
 	public T SomeOrDefault(T defaultValue)
 		=> _type is OptionType.Some 
 			? _value!
 			: defaultValue;
 
+	/// <summary>
+	/// Creates a new optional value that is flagged as present.
+	/// </summary>
+	/// <param name="value">The value.</param>
 	public static implicit operator Option<T>(T value)
 		=> new(OptionType.Some, value);
 
+	/// <summary>
+	/// Gets the value of an option value if its <see cref="Type"/> is <seealso cref="OptionType.Some"/>
+	/// </summary>
+	/// <param name="option">The optional value.</param>
+	/// <exception cref="InvalidCastException">If the <see cref="Type"/> is not <seealso cref="OptionType.Some"/>.</exception>
 	public static explicit operator T(Option<T> option)
 	{
 		if (option._type is not OptionType.Some)
@@ -69,9 +119,17 @@ public static explicit operator T(Option<T> option)
 		return option._value!;
 	}
 
+	/// <summary>
+	/// Changes the type of an optional value.
+	/// </summary>
+	/// <param name="option">The optional value.</param>
 	public static explicit operator Option<object>(Option<T> option)
 		=> new(option._type, option._value);
 
+	/// <summary>
+	/// Changes the type of an optional value.
+	/// </summary>
+	/// <param name="option">The optional value.</param>
 	public static explicit operator Option<T>(Option<object> option)
 		=> new(option._type, option._value is T value ? value : default);
 
diff --git a/src/Uno.Extensions.Core/OptionType.cs b/src/Uno.Extensions.Core/OptionType.cs
index 3552f6e99d..ee680563bc 100644
--- a/src/Uno.Extensions.Core/OptionType.cs
+++ b/src/Uno.Extensions.Core/OptionType.cs
@@ -1,15 +1,25 @@
-#pragma warning disable CS1591 // XML Doc, will be moved elsewhere
-
-using System;
+using System;
 using System.Linq;
 
 namespace Uno.Extensions;
 
+/// <summary>
+/// Defines the possible types of an <see cref="Option{T}"/>
+/// </summary>
 public enum OptionType : short
 {
+	/// <summary>
+	/// Indicates the absence of a value
+	/// </summary>
 	None = 0, // The default so default(Option<T>) == Option<T>.None
 
+	/// <summary>
+	/// Indicates the presence of a value
+	/// </summary>
 	Some = 1,
 
+	/// <summary>
+	/// Indicates that incertitude about the presence or the absence of a value.
+	/// </summary>
 	Undefined = -1,
 }