Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uno.Extensions.Toolkit is confusing #1627

Closed
12 tasks
MartinZikmund opened this issue Jul 9, 2023 · 3 comments
Closed
12 tasks

Uno.Extensions.Toolkit is confusing #1627

MartinZikmund opened this issue Jul 9, 2023 · 3 comments
Assignees
@nickrandolph
Labels
kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification.

Comments

@MartinZikmund
Copy link
Member

MartinZikmund commented Jul 9, 2023 •
edited
Loading

What would you like clarification on:

Uno.Extensions.Toolkit is easy to be confused with Uno.UI.Toolkit and Uno.Toolkit.UI - especially as it has nothing to do with either of them 🤯 . It should definitely be either more documented or potentially renamed as part of breaking changes to something akin to "Helpers". It seems that's what it currently contains overall.

Concern?

  • Usage in industry
  • Clarification of capabilities
  • Getting started with Uno
  • Developing with Uno
  • Contributing to the Uno project
  • Publishing your application
  • Support
  • Other (please specify):

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • Windows

Anything else we need to know?
@MartinZikmund MartinZikmund added kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification. labels Jul 9, 2023
@nickrandolph nickrandolph self-assigned this Jul 10, 2023
@nickrandolph
Copy link
Contributor

A couple of things:

  • Uno.Extensions.Toolkit and Toolkit.UI/WinUI can be removed, with the existing classes all moved to Uno.Extensions.Core since they no longer rely on Uno.Toolkit
  • Uno.Extensions can be removed completely

@nickrandolph nickrandolph mentioned this issue Jul 10, 2023
Merged
4 tasks
@francoistanguay
Copy link
Contributor

Shouldnt Uno.Extensions.Core just be called Uno.Extensions?

@nickrandolph
Copy link
Contributor

Shouldnt Uno.Extensions.Core just be called Uno.Extensions?

Perhaps, although I would prefer Uno.Extensions to be used as a meta package, making it easier to simply add all extension packages at once - I think this is something to be considered considering how much of a pain it is to a) add extension packages b) update the versions at same time etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickrandolph nickrandolph

Labels
kind/consumer-experience Categorizes issue or PR as related to improving the experience of consumers kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinZikmund @nickrandolph @francoistanguay