Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP driver bug #268

Closed
olivbau opened this issue Jul 8, 2023 · 1 comment · Fixed by #365
Closed

HTTP driver bug #268

olivbau opened this issue Jul 8, 2023 · 1 comment · Fixed by #365
Labels
bug Something isn't working

Comments

@olivbau
Copy link

olivbau commented Jul 8, 2023

Environment

windows
node v18.16.0

Reproduction

Run a http driver

Describe the bug

http driver seems to return a string "null" on getItem when item is missing, instead of a "real" null object

Additional context

No response

Logs

No response
@pi0 pi0 added the bug Something isn't working label Jul 8, 2023
@itpropro itpropro mentioned this issue Jan 3, 2024
Merged
8 tasks
@itpropro
Copy link
Member

itpropro commented Jan 3, 2024

I couldn't reproduce this @olivbau, but added some tests for null checks in #365. You should also note that adding a string "null" as a value will result in a null object as return. This is due to JSON parsing with destr, which behaves exactly as JSON.pase in this matter.
Feel free to reopen with a reproduction, if this still happens for you.

@itpropro itpropro closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(http): add tests for null value unjs/unstorage
3 participants
@pi0 @olivbau @itpropro