Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic V2.0 bump? #175

Closed
leogaggl opened this issue Jan 30, 2024 · 5 comments
Closed

Pydantic V2.0 bump? #175

leogaggl opened this issue Jan 30, 2024 · 5 comments

Comments

@leogaggl
Copy link

Is your feature request related to a problem? Please describe.
I would love to include this library in one of my projects which proxies a local MQTT server to the outside. However, there is a dependency clash on Pydantic as fastapi-mqtt (^2.1.0) and ha-mqtt-discoverable (^0.13.1) can not agree on the Pydantic version. And the other project requires V2.

Describe the solution you'd like
It would be great if the version could be bumped. I can already see a PR from dependabot --> #174

It would be great if that could be merged so the the library can be included.

@unixorn
Copy link
Owner

unixorn commented Jan 30, 2024

I haven't had time to test the PR - I'm going to try and look at it this weekend. It's a major version bump and I don't want to break things by merging it.

@leogaggl
Copy link
Author

leogaggl commented Jan 30, 2024 via email

@unixorn
Copy link
Owner

unixorn commented May 19, 2024

Closed by #191

Sorry this took so long, I broke my ankle in October and am still doing physical therapy after the surgery, so I didn't have time to confirm that things still worked.

@unixorn unixorn closed this as completed May 19, 2024
@leogaggl
Copy link
Author

Thanks for the update!

No worries at all. I hope your ankle gets better soon!

Keep up the good work. Appreciate the library!

@unixorn
Copy link
Owner

unixorn commented May 19, 2024

Thank you! I'm glad to hear it is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants