From 70af20f9699e4bacc3fb8f632a6f1ea0379fc051 Mon Sep 17 00:00:00 2001
From: Andrii Rosa <andriirosa@fb.com>
Date: Fri, 8 Nov 2024 11:43:06 -0800
Subject: [PATCH] Support out of tree builds

---
 .gitignore                 |  2 +-
 pom.xml                    | 83 ++++++++++++++++++++++++++++++++++++++
 presto-docs/pom.xml        | 10 ++---
 presto-thrift-spec/pom.xml |  4 +-
 4 files changed, 91 insertions(+), 8 deletions(-)

diff --git a/.gitignore b/.gitignore
index dc9c1042f96fc..a4512f9f794d9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,7 +1,7 @@
 *.iml
 *.ipr
 *.iws
-target/
+target
 /var
 /*/var/
 /presto-product-tests/**/var/
diff --git a/pom.xml b/pom.xml
index a2dc8d37c01e4..4852f4f7b4663 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2671,5 +2671,88 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>out-of-tree-build</id>
+            <activation>
+                <activeByDefault>false</activeByDefault>
+                <property>
+                    <name>out-of-tree-build-root</name>
+                </property>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.codehaus.mojo</groupId>
+                        <artifactId>exec-maven-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <id>unlink-out-of-tree-build-directory</id>
+                                <goals><goal>exec</goal></goals>
+                                <phase>pre-clean</phase>
+                                <configuration>
+                                    <executable>rm</executable>
+                                    <arguments>
+                                        <argument>-rf</argument>
+                                        <argument>${project.build.directory}</argument>
+                                    </arguments>
+                                </configuration>
+                            </execution>
+                            <execution>
+                                <id>remove-out-of-tree-build-directory</id>
+                                <goals><goal>exec</goal></goals>
+                                <phase>pre-clean</phase>
+                                <configuration>
+                                    <executable>rm</executable>
+                                    <arguments>
+                                        <argument>-rf</argument>
+                                        <argument>${out-of-tree-build-root}/${project.groupId}:${project.artifactId}</argument>
+                                    </arguments>
+                                </configuration>
+                            </execution>
+                            <execution>
+                                <id>create-out-of-tree-build-directory</id>
+                                <goals><goal>exec</goal></goals>
+                                <phase>validate</phase>
+                                <configuration>
+                                    <executable>mkdir</executable>
+                                    <arguments>
+                                        <argument>-p</argument>
+                                        <argument>${out-of-tree-build-root}/${project.groupId}:${project.artifactId}</argument>
+                                    </arguments>
+                                </configuration>
+                            </execution>
+                            <execution>
+                                <id>link-out-of-tree-build-directory</id>
+                                <goals><goal>exec</goal></goals>
+                                <phase>validate</phase>
+                                <configuration>
+                                    <executable>ln</executable>
+                                    <arguments>
+                                        <argument>-sT</argument>
+                                        <argument>${out-of-tree-build-root}/${project.groupId}:${project.artifactId}</argument>
+                                        <argument>${project.build.directory}</argument>
+                                    </arguments>
+                                </configuration>
+                            </execution>
+                        </executions>
+                        <configuration>
+                            <longModulepath>false</longModulepath>
+                        </configuration>
+                    </plugin>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-checkstyle-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <id>checkstyle</id>
+                                <configuration>
+                                    <cacheFile>${out-of-tree-build-root}/${project.groupId}:${project.artifactId}/checkstyle-cachefile</cacheFile>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
     </profiles>
 </project>
diff --git a/presto-docs/pom.xml b/presto-docs/pom.xml
index 7e56cc9ead566..316f59381b81a 100644
--- a/presto-docs/pom.xml
+++ b/presto-docs/pom.xml
@@ -40,12 +40,12 @@
                 <artifactId>drift-maven-plugin</artifactId>
                 <executions>
                     <execution>
-                        <phase>validate</phase>
+                        <phase>generate-sources</phase>
                         <goals>
                             <goal>generate-thrift-idl</goal>
                         </goals>
                         <configuration>
-                            <outputFile>${project.build.directory}/PrestoThriftService.thrift</outputFile>
+                            <outputFile>${project.build.directory}/thrift/PrestoThriftService.thrift</outputFile>
                             <classes>
                                 <class>com.facebook.presto.thrift.api.connector.PrestoThriftService</class>
                             </classes>
@@ -82,7 +82,7 @@
                     </execution>
                     <execution>
                         <id>validate-thrift-idl</id>
-                        <phase>validate</phase>
+                        <phase>process-sources</phase>
                         <goals>
                             <goal>exec</goal>
                         </goals>
@@ -92,13 +92,13 @@
                                 <argument>-b</argument>
                                 <argument>-c</argument>
                                 <argument>${project.basedir}/src/main/sphinx/include/PrestoThriftService.thrift</argument>
-                                <argument>${project.build.directory}/PrestoThriftService.thrift</argument>
+                                <argument>${project.build.directory}/thrift/PrestoThriftService.thrift</argument>
                             </arguments>
                         </configuration>
                     </execution>
                     <execution>
                         <id>run-sphinx</id>
-                        <phase>package</phase>
+                        <phase>compile</phase>
                         <goals>
                             <goal>exec</goal>
                         </goals>
diff --git a/presto-thrift-spec/pom.xml b/presto-thrift-spec/pom.xml
index 556b04e46689d..5bb6a1eb944a0 100644
--- a/presto-thrift-spec/pom.xml
+++ b/presto-thrift-spec/pom.xml
@@ -52,7 +52,7 @@
                                 <class>com.facebook.presto.execution.TaskStatus</class>
                             </classes>
                             <recursive>true</recursive>
-                            <outputFile>target/presto-internal-${project.version}.thrift</outputFile>
+                            <outputFile>target/thrift/presto-internal-${project.version}.thrift</outputFile>
                         </configuration>
                     </execution>
                 </executions>
@@ -70,7 +70,7 @@
                         <configuration>
                             <artifacts>
                                 <artifact>
-                                    <file>target/presto-internal-${project.version}.thrift</file>
+                                    <file>target/thrift/presto-internal-${project.version}.thrift</file>
                                     <type>thrift</type>
                                 </artifact>
                             </artifacts>