Skip to content

Commit 6ee450c

Browse files
authored
Revert DataSize change for public-facing API (prestodb#24682)
* Revert API change for QueryStats * Revert related tests * Revert UI change * Revert presto-spark-base change
1 parent c29b385 commit 6ee450c

File tree

20 files changed

+518
-513
lines changed

20 files changed

+518
-513
lines changed

presto-main/src/main/java/com/facebook/presto/event/QueryMonitor.java

+11-11
Original file line numberDiff line numberDiff line change
@@ -436,21 +436,21 @@ private QueryStatistics createQueryStatistics(QueryInfo queryInfo)
436436
Optional.of(ofMillis(queryStats.getAnalysisTime().toMillis())),
437437
ofMillis(queryStats.getExecutionTime().toMillis()),
438438
queryStats.getPeakRunningTasks(),
439-
queryStats.getPeakUserMemoryReservationInBytes(),
440-
queryStats.getPeakTotalMemoryReservationInBytes(),
441-
queryStats.getPeakTaskUserMemoryInBytes(),
442-
queryStats.getPeakTaskTotalMemoryInBytes(),
443-
queryStats.getPeakNodeTotalMemoryInBytes(),
444-
queryStats.getShuffledDataSizeInBytes(),
439+
queryStats.getPeakUserMemoryReservation().toBytes(),
440+
queryStats.getPeakTotalMemoryReservation().toBytes(),
441+
queryStats.getPeakTaskUserMemory().toBytes(),
442+
queryStats.getPeakTaskTotalMemory().toBytes(),
443+
queryStats.getPeakNodeTotalMemory().toBytes(),
444+
queryStats.getShuffledDataSize().toBytes(),
445445
queryStats.getShuffledPositions(),
446-
queryStats.getRawInputDataSizeInBytes(),
446+
queryStats.getRawInputDataSize().toBytes(),
447447
queryStats.getRawInputPositions(),
448-
queryStats.getOutputDataSizeInBytes(),
448+
queryStats.getOutputDataSize().toBytes(),
449449
queryStats.getOutputPositions(),
450-
queryStats.getWrittenOutputLogicalDataSizeInBytes(),
450+
queryStats.getWrittenOutputLogicalDataSize().toBytes(),
451451
queryStats.getWrittenOutputPositions(),
452-
queryStats.getWrittenIntermediatePhysicalDataSizeInBytes(),
453-
queryStats.getSpilledDataSizeInBytes(),
452+
queryStats.getWrittenIntermediatePhysicalDataSize().toBytes(),
453+
queryStats.getSpilledDataSize().toBytes(),
454454
queryStats.getCumulativeUserMemory(),
455455
queryStats.getCumulativeTotalMemory(),
456456
queryStats.getCompletedDrivers(),

presto-main/src/main/java/com/facebook/presto/execution/QueryStateMachine.java

+15-15
Original file line numberDiff line numberDiff line change
@@ -1304,33 +1304,33 @@ private static QueryStats pruneQueryStats(QueryStats queryStats)
13041304
queryStats.getCompletedDrivers(),
13051305
queryStats.getCumulativeUserMemory(),
13061306
queryStats.getCumulativeTotalMemory(),
1307-
queryStats.getUserMemoryReservationInBytes(),
1308-
queryStats.getTotalMemoryReservationInBytes(),
1309-
queryStats.getPeakUserMemoryReservationInBytes(),
1310-
queryStats.getPeakTotalMemoryReservationInBytes(),
1311-
queryStats.getPeakTaskUserMemoryInBytes(),
1312-
queryStats.getPeakTaskTotalMemoryInBytes(),
1313-
queryStats.getPeakNodeTotalMemoryInBytes(),
1307+
queryStats.getUserMemoryReservation(),
1308+
queryStats.getTotalMemoryReservation(),
1309+
queryStats.getPeakUserMemoryReservation(),
1310+
queryStats.getPeakTotalMemoryReservation(),
1311+
queryStats.getPeakTaskUserMemory(),
1312+
queryStats.getPeakTaskTotalMemory(),
1313+
queryStats.getPeakNodeTotalMemory(),
13141314
queryStats.isScheduled(),
13151315
queryStats.getTotalScheduledTime(),
13161316
queryStats.getTotalCpuTime(),
13171317
queryStats.getRetriedCpuTime(),
13181318
queryStats.getTotalBlockedTime(),
13191319
queryStats.isFullyBlocked(),
13201320
queryStats.getBlockedReasons(),
1321-
queryStats.getTotalAllocationInBytes(),
1322-
queryStats.getRawInputDataSizeInBytes(),
1321+
queryStats.getTotalAllocation(),
1322+
queryStats.getRawInputDataSize(),
13231323
queryStats.getRawInputPositions(),
1324-
queryStats.getProcessedInputDataSizeInBytes(),
1324+
queryStats.getProcessedInputDataSize(),
13251325
queryStats.getProcessedInputPositions(),
1326-
queryStats.getShuffledDataSizeInBytes(),
1326+
queryStats.getShuffledDataSize(),
13271327
queryStats.getShuffledPositions(),
1328-
queryStats.getOutputDataSizeInBytes(),
1328+
queryStats.getOutputDataSize(),
13291329
queryStats.getOutputPositions(),
13301330
queryStats.getWrittenOutputPositions(),
1331-
queryStats.getWrittenOutputLogicalDataSizeInBytes(),
1332-
queryStats.getWrittenOutputPhysicalDataSizeInBytes(),
1333-
queryStats.getWrittenIntermediatePhysicalDataSizeInBytes(),
1331+
queryStats.getWrittenOutputLogicalDataSize(),
1332+
queryStats.getWrittenOutputPhysicalDataSize(),
1333+
queryStats.getWrittenIntermediatePhysicalDataSize(),
13341334
queryStats.getStageGcStatistics(),
13351335
ImmutableList.of(), // Remove the operator summaries as OperatorInfo (especially ExchangeClientStatus) can hold onto a large amount of memory
13361336
queryStats.getRuntimeStats());

0 commit comments

Comments
 (0)