Skip to content

Commit 28da88d

Browse files
shangm2NikhilCollooru
authored andcommitted
Convert DataSize for tests
1 parent 0711cfa commit 28da88d

38 files changed

+558
-573
lines changed

presto-main/src/test/java/com/facebook/presto/execution/MockManagedQueryExecution.java

+4-5
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,14 @@
4242
import static com.facebook.presto.execution.QueryState.WAITING_FOR_PREREQUISITES;
4343
import static com.facebook.presto.testing.TestingSession.testSessionBuilder;
4444
import static io.airlift.units.DataSize.Unit.BYTE;
45-
import static io.airlift.units.DataSize.succinctBytes;
4645
import static java.util.concurrent.TimeUnit.MILLISECONDS;
4746
import static java.util.concurrent.TimeUnit.NANOSECONDS;
4847

4948
public class MockManagedQueryExecution
5049
implements ManagedQueryExecution
5150
{
5251
private final List<StateChangeListener<QueryState>> listeners = new ArrayList<>();
53-
private final DataSize memoryUsage;
52+
private final long memoryUsage;
5453
private final Duration cpuUsage;
5554
private final Session session;
5655
private QueryState state = WAITING_FOR_PREREQUISITES;
@@ -75,7 +74,7 @@ public MockManagedQueryExecution(long memoryUsage, String queryId, int priority,
7574

7675
public MockManagedQueryExecution(long memoryUsage, String queryId, int priority, Duration cpuUsage, ResourceGroupId resourceGroupId)
7776
{
78-
this.memoryUsage = succinctBytes(memoryUsage);
77+
this.memoryUsage = memoryUsage;
7978
this.cpuUsage = cpuUsage;
8079
this.session = testSessionBuilder()
8180
.setSystemProperty(QUERY_PRIORITY, String.valueOf(priority))
@@ -161,13 +160,13 @@ public BasicQueryInfo getBasicQueryInfo()
161160
}
162161

163162
@Override
164-
public DataSize getUserMemoryReservation()
163+
public long getUserMemoryReservationInBytes()
165164
{
166165
return memoryUsage;
167166
}
168167

169168
@Override
170-
public DataSize getTotalMemoryReservation()
169+
public long getTotalMemoryReservationInBytes()
171170
{
172171
return memoryUsage;
173172
}

presto-main/src/test/java/com/facebook/presto/execution/MockQueryExecution.java

+21-22
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.facebook.presto.spi.resourceGroups.ResourceGroupQueryLimits;
2121
import com.facebook.presto.sql.planner.Plan;
2222
import com.google.common.util.concurrent.ListenableFuture;
23-
import io.airlift.units.DataSize;
2423
import io.airlift.units.Duration;
2524
import org.joda.time.DateTime;
2625

@@ -67,11 +66,11 @@ public ListenableFuture<QueryState> getStateChange(QueryState currentState)
6766

6867
@Override
6968
public void addStateChangeListener(StateMachine.StateChangeListener<QueryState> stateChangeListener)
70-
{ }
69+
{}
7170

7271
@Override
7372
public void addOutputInfoListener(Consumer<QueryOutputInfo> listener)
74-
{ }
73+
{}
7574

7675
@Override
7776
public Plan getQueryPlan()
@@ -110,15 +109,15 @@ public Duration getTotalCpuTime()
110109
}
111110

112111
@Override
113-
public DataSize getRawInputDataSize()
112+
public long getRawInputDataSizeInBytes()
114113
{
115-
return null;
114+
return 0;
116115
}
117116

118117
@Override
119-
public DataSize getWrittenIntermediateDataSize()
118+
public long getWrittenIntermediateDataSizeInBytes()
120119
{
121-
return null;
120+
return 0;
122121
}
123122

124123
@Override
@@ -128,9 +127,9 @@ public long getOutputPositions()
128127
}
129128

130129
@Override
131-
public DataSize getOutputDataSize()
130+
public long getOutputDataSizeInBytes()
132131
{
133-
return null;
132+
return 0;
134133
}
135134

136135
@Override
@@ -140,15 +139,15 @@ public int getRunningTaskCount()
140139
}
141140

142141
@Override
143-
public DataSize getUserMemoryReservation()
142+
public long getUserMemoryReservationInBytes()
144143
{
145-
return null;
144+
return 0;
146145
}
147146

148147
@Override
149-
public DataSize getTotalMemoryReservation()
148+
public long getTotalMemoryReservationInBytes()
150149
{
151-
return null;
150+
return 0;
152151
}
153152

154153
@Override
@@ -218,37 +217,37 @@ public Optional<Throwable> getFailureReason()
218217

219218
@Override
220219
public void pruneExpiredQueryInfo()
221-
{ }
220+
{}
222221

223222
@Override
224223
public void pruneFinishedQueryInfo()
225-
{ }
224+
{}
226225

227226
@Override
228227
public void setResourceGroupQueryLimits(ResourceGroupQueryLimits resourceGroupQueryLimits)
229-
{ }
228+
{}
230229

231230
@Override
232231
public void setMemoryPool(VersionedMemoryPoolId poolId)
233-
{ }
232+
{}
234233

235234
@Override
236235
public void start()
237-
{ }
236+
{}
238237

239238
@Override
240239
public void cancelQuery()
241-
{ }
240+
{}
242241

243242
@Override
244243
public void cancelStage(StageId stageId)
245-
{ }
244+
{}
246245

247246
@Override
248247
public void recordHeartbeat()
249-
{ }
248+
{}
250249

251250
@Override
252251
public void addFinalQueryInfoListener(StateMachine.StateChangeListener<QueryInfo> stateChangeListener)
253-
{ }
252+
{}
254253
}

presto-main/src/test/java/com/facebook/presto/execution/MockRemoteTaskFactory.java

+4-5
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@
9292
import static com.facebook.presto.util.Failures.toFailures;
9393
import static com.google.common.base.Preconditions.checkArgument;
9494
import static com.google.common.util.concurrent.Futures.nonCancellationPropagating;
95-
import static io.airlift.units.DataSize.Unit.BYTE;
9695
import static io.airlift.units.DataSize.Unit.GIGABYTE;
9796
import static io.airlift.units.DataSize.Unit.MEGABYTE;
9897
import static java.lang.Math.addExact;
@@ -240,7 +239,7 @@ public MockRemoteTask(TaskId taskId,
240239
taskId,
241240
TASK_INSTANCE_ID.toString(),
242241
executor,
243-
new DataSize(1, BYTE),
242+
1L,
244243
() -> new SimpleLocalMemoryContext(newSimpleAggregatedMemoryContext(), "test"),
245244
new SpoolingOutputBufferFactory(new FeaturesConfig()));
246245

@@ -444,9 +443,9 @@ public synchronized void noMoreSplits(PlanNodeId sourceId)
444443
noMoreSplits.add(sourceId);
445444

446445
boolean allSourcesComplete = Stream.concat(
447-
fragment.getTableScanSchedulingOrder().stream(),
448-
fragment.getRemoteSourceNodes().stream()
449-
.map(PlanNode::getId))
446+
fragment.getTableScanSchedulingOrder().stream(),
447+
fragment.getRemoteSourceNodes().stream()
448+
.map(PlanNode::getId))
450449
.allMatch(noMoreSplits::contains);
451450

452451
if (allSourcesComplete) {

presto-main/src/test/java/com/facebook/presto/execution/TestMemoryRevokingScheduler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,7 @@ private SqlTask newSqlTask(QueryId queryId, MemoryPool memoryPool)
796796
new MockExchangeClientSupplier(),
797797
singleThreadedExecutor,
798798
Functions.identity(),
799-
new DataSize(32, MEGABYTE),
799+
new DataSize(32, MEGABYTE).toBytes(),
800800
new CounterStat(),
801801
new SpoolingOutputBufferFactory(new FeaturesConfig()));
802802
}

presto-main/src/test/java/com/facebook/presto/execution/TestQueryLimit.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@
3333
public class TestQueryLimit
3434
{
3535
private static final QueryLimit<Duration> QUERY_LIMIT_DURATION = createDurationLimit(new Duration(1, HOURS), SYSTEM);
36-
private static final QueryLimit<DataSize> QUERY_LIMIT_DATA_SIZE = createDataSizeLimit(new DataSize(1, MEGABYTE), RESOURCE_GROUP);
36+
private static final QueryLimit<Long> QUERY_LIMIT_DATA_SIZE = createDataSizeLimit(new DataSize(1, MEGABYTE).toBytes(), RESOURCE_GROUP);
3737

3838
@Test
3939
public void testGetLimit()
4040
{
4141
assertEquals(QUERY_LIMIT_DURATION.getLimit(), new Duration(1, HOURS));
42-
assertEquals(QUERY_LIMIT_DATA_SIZE.getLimit(), new DataSize(1, MEGABYTE));
42+
assertEquals(QUERY_LIMIT_DATA_SIZE.getLimit(), new DataSize(1, MEGABYTE).toBytes());
4343
}
4444

4545
@Test
@@ -57,8 +57,8 @@ public void testGetMinimum()
5757
QueryLimit<Duration> shortLimit = createDurationLimit(new Duration(1, MINUTES), RESOURCE_GROUP);
5858
assertEquals(getMinimum(QUERY_LIMIT_DURATION, longLimit, shortLimit), shortLimit);
5959

60-
QueryLimit<DataSize> largeLimit = createDataSizeLimit(new DataSize(2, MEGABYTE), QUERY);
61-
QueryLimit<DataSize> smallLimit = createDataSizeLimit(new DataSize(1, BYTE), RESOURCE_GROUP);
60+
QueryLimit<Long> largeLimit = createDataSizeLimit(new DataSize(2, MEGABYTE).toBytes(), QUERY);
61+
QueryLimit<Long> smallLimit = createDataSizeLimit(new DataSize(1, BYTE).toBytes(), RESOURCE_GROUP);
6262
assertEquals(getMinimum(smallLimit, QUERY_LIMIT_DATA_SIZE, largeLimit), smallLimit);
6363
assertEquals(getMinimum(null, QUERY_LIMIT_DATA_SIZE, largeLimit), QUERY_LIMIT_DATA_SIZE);
6464
assertEquals(getMinimum(null, largeLimit, null, null, QUERY_LIMIT_DATA_SIZE), QUERY_LIMIT_DATA_SIZE);

0 commit comments

Comments
 (0)