Record http client transaction create delay time

Author: kewang1024

presto-native-execution/presto_cpp/main/common/Counters.cpp

@@ -32,6 +32,17 @@ void registerPrestoMetrics() {
   DEFINE_METRIC(kCounterHTTPRequestLatencyMs, facebook::velox::StatType::AVG);
   DEFINE_METRIC(
       kCounterHttpClientNumConnectionsCreated, facebook::velox::StatType::SUM);
+  // Tracks http client transaction create delay in range of [0, 30s] with
+  // 30 buckets and reports P50, P90, P99, and P100.
+  DEFINE_HISTOGRAM_METRIC(
+      kCounterHTTPClientTransactionCreateDelay,
+      1'000,
+      0,
+      30'000,
+      50,
+      90,
+      99,
+      100);
   DEFINE_METRIC(kCounterNumQueryContexts, facebook::velox::StatType::AVG);
   DEFINE_METRIC(kCounterNumTasks, facebook::velox::StatType::AVG);
   DEFINE_METRIC(kCounterNumTasksBytesProcessed, facebook::velox::StatType::AVG);

presto-native-execution/presto_cpp/main/common/Counters.h

@@ -41,6 +41,8 @@ constexpr folly::StringPiece kCounterHTTPRequestLatencyMs{
 
 constexpr folly::StringPiece kCounterHttpClientNumConnectionsCreated{
     "presto_cpp.http.client.num_connections_created"};
+constexpr folly::StringPiece kCounterHTTPClientTransactionCreateDelay{
+    "presto_cpp.http.client.transaction_create_delay_ms"};
 /// Peak number of bytes queued in PrestoExchangeSource waiting for consume.
 constexpr folly::StringPiece kCounterExchangeSourcePeakQueuedBytes{
     "presto_cpp.exchange_source_peak_queued_bytes"};

presto-native-execution/presto_cpp/main/http/HttpClient.cpp

@@ -20,8 +20,10 @@
 #include <folly/synchronization/Latch.h>
 #include <velox/common/base/Exceptions.h>
 #include "presto_cpp/main/common/Configs.h"
+#include "presto_cpp/main/common/Counters.h"
 #include "presto_cpp/main/common/Utils.h"
 #include "presto_cpp/main/http/HttpClient.h"
+#include "velox/common/base/StatsReporter.h"
 
 namespace facebook::presto::http {
 
@@ -168,7 +170,8 @@ HttpResponse::nextAllocationSize(uint64_t dataLength) const {
 }
 
 std::string HttpResponse::dumpBodyChain() const {
-  return bodyChain_.empty() ? "Empty response" : util::extractMessageBody(bodyChain_);
+  return bodyChain_.empty() ? "Empty response"
+                            : util::extractMessageBody(bodyChain_);
 }
 
 class ResponseHandler : public proxygen::HTTPTransactionHandler {
@@ -448,7 +451,10 @@ folly::SemiFuture<proxygen::HTTPTransaction*> HttpClient::createTransaction(
   }
   auto idleSessionFuture = idleSessions_->getIdleSession();
   auto getFromIdleSession =
-      [self = shared_from_this(), this, handler](
+      [self = shared_from_this(),
+       this,
+       handler,
+       startTimeMs = velox::getCurrentTimeMs()](
           proxygen::HTTPSessionBase* session) -> proxygen::HTTPTransaction* {
     if (!session) {
       return nullptr;
@@ -472,6 +478,9 @@ folly::SemiFuture<proxygen::HTTPTransaction*> HttpClient::createTransaction(
         nullptr,
         nullptr);
     sessionPool_->putSession(session);
+    RECORD_HISTOGRAM_METRIC_VALUE(
+        kCounterHTTPClientTransactionCreateDelay,
+        velox::getCurrentTimeMs() - startTimeMs);
     return sessionPool_->getTransaction(handler);
   };
   if (idleSessionFuture.isReady()) {