Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #250

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Upgrade dependencies #250

merged 1 commit into from
Feb 20, 2025

Conversation

bachase
Copy link
Collaborator

@bachase bachase commented Feb 20, 2025

#125 will automate this, but for now, upgrading to the latest version of pyqasm and qbraid to benefit from improvements in parsing speed during benchmark runs.

Fixes #233

Copy link
Collaborator

@jordandsullivan jordandsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@bachase bachase merged commit da6395c into main Feb 20, 2025
2 checks passed
@bachase bachase deleted the 233-upgrade-pyqasm branch February 20, 2025 21:51
@jordandsullivan
Copy link
Collaborator

Taking a look at the latest benchmarks, it looks like PyTKET suddenly slower with these updates. There wasn't a change to the PyTKET version though, so I'm not sure what could be causing this.
17400910229213713367557020631448

@bachase
Copy link
Collaborator Author

bachase commented Feb 20, 2025

Taking a look at the latest benchmarks, it looks like PyTKET suddenly slower with these updates. There wasn't a change to the PyTKET version though, so I'm not sure what could be causing this. 17400910229213713367557020631448

Yes, but also looks like some drift for others over the last few runs as well? I suggest we consider using the pinned versions in the lock file to at least remove that degree of freedom in case some of the common dependencies are changing silently? (We can enable dependabot to get them auto-upgrading in a more controlled manner).

I'm less familiar with how consistent the runner instance is, and how well we are isolating the individual runs

@bachase
Copy link
Collaborator Author

bachase commented Feb 20, 2025

I wonder if the noise simulations have some internal parallelization too. I can make a new ticket to investigate this tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance reading qasm
2 participants