Add CI for testing #135
Merged
Add CI for testing #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got things to work out by installing an editable version of |
jordandsullivan
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
LGTM thanks!
Eventually perhaps we should also add a local test to make sure our benchmark pipeline works (perhaps using https://github.com/nektos/act as you suggested elsewhere), but that can wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the 🥫.
fixes #52
Reviewer notes
pytest uccis the command being used to run the tests. I wasn't able to find any docs about this, so just want to confirm this is the correct command.benchmarksmodule. I will wait to resolve this until after Re-organize files so QASM circuits live in a different directory than… #128 is merged.