Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make comparison benchmark code for external compiler configurations clearer #242

Open
willzeng opened this issue Feb 18, 2025 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@willzeng
Copy link
Collaborator

Right now this code is a bit hidden: https://github.com/unitaryfund/ucc/blob/main/benchmarks/scripts/common.py#L89-L110

This could
(1) be refactored to make it easier for contributors to suggest updates to the defaults that we use and
(2) be included in the docs so that contributors can easily find what defaults we mean when we mention qiskit and pytket on the benchmark plots

@willzeng willzeng added the feature New feature or request label Feb 18, 2025
@bachase
Copy link
Collaborator

bachase commented Feb 18, 2025

I'll focus on option 2 for as part of the next milestone, but will consider a refactored version as part of #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants