Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark plot resolution to monthly #200

Open
willzeng opened this issue Jan 27, 2025 · 3 comments · May be fixed by #254
Open

Update benchmark plot resolution to monthly #200

willzeng opened this issue Jan 27, 2025 · 3 comments · May be fixed by #254
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@willzeng
Copy link
Collaborator

Perhaps updating this to instead plot by month will scale better over time:

Image

Otherwise will get quite long quickly

@willzeng willzeng added the documentation Improvements or additions to documentation label Jan 27, 2025
@jordandsullivan jordandsullivan added this to the 0.4.3 milestone Jan 29, 2025
@Misty-W
Copy link
Collaborator

Misty-W commented Feb 11, 2025

Suggest to make this per stable release.

@jordandsullivan
Copy link
Collaborator

Let's do per release of each compiler as well.

@bachase
Copy link
Collaborator

bachase commented Feb 18, 2025

@jordandsullivan as part of #78 , there was a change in creating the docker file to just run

ucc/Dockerfile

Line 24 in fde89f6

RUN --mount=type=cache,target=/tmp/poetry_cache poetry install --no-root
. This just installs the package versions as reflected in poetry.lock file, so will no longer automatically pick up the latest versions of any external compilers. I will open a PR to instead install the latest (compatible) versions when creating the dockerfile as was done previously.

However, that's another point in favor of externalizing the benchmarking code as discussed in #210, as the dependencies specified in pyproject.toml and the resulting poetry.lock file mean different things for developers of the ucc library from users or benchmarking runs. We don't need to change anything quite yet, but it will complicate workflows like upgrading to the latest version of pytket for benchmarking, but not yet for any places where we build on top of pyket compiler passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants