Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No provider should fail with MissingDataKey if it was built with a key but that key has no locales #3610

Closed
Manishearth opened this issue Jul 3, 2023 · 2 comments · Fixed by #3682
Closed

No provider should fail with MissingDataKey if it was built with a key but that key has no locales #3610

Manishearth opened this issue Jul 3, 2023 · 2 comments · Fixed by #3682
Assignees
@robertbastian
Labels
A-data Area: Data coverage or quality C-data-infra Component: provider, datagen, fallback, adapters
Milestone
1.3 Blocking ⟨P1⟩

Comments

@Manishearth
Copy link
Member

Manishearth commented Jul 3, 2023 •
edited by robertbastian
Loading

Spawned out of #3575

If a data provider is built with a key but the key has no data, it should not error with MissingDataKey, it should error with MissingLocale.

BlobDataProvider fixed this in #3551. The adapters should just work with this (worth quickly checking if forking by key works correctly)

FsDataProvider needs to be fixed. Probably with a manifest change or some dummy file.
@Manishearth Manishearth added the A-data Area: Data coverage or quality label Jul 3, 2023
@Manishearth Manishearth mentioned this issue Jul 3, 2023
Closed
@robertbastian
Copy link
Member

FsDataProvider needs to be fixed. Probably with a manifest change or some dummy file.

It actually works already with directory presence, the exporter just has to be updated to create empty directories.

@robertbastian robertbastian mentioned this issue Jul 14, 2023
Merged
@sffc
Copy link
Member

sffc commented Jul 20, 2023

Reopening due to requested changes on #3682

@sffc sffc reopened this Jul 20, 2023
@sffc sffc added this to the 1.3 Blocking ⟨P1⟩ milestone Jul 20, 2023
@sffc sffc added the C-data-infra Component: provider, datagen, fallback, adapters label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertbastian robertbastian

Labels
A-data Area: Data coverage or quality C-data-infra Component: provider, datagen, fallback, adapters
Projects
None yet
Milestone
1.3 Blocking ⟨P1⟩
Development

Successfully merging a pull request may close this issue.

Correct error types for icu_provider_fs robertbastian/icu4x
3 participants
@sffc @Manishearth @robertbastian