Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] rc5 ready? #12

Closed
rmoscowitz opened this issue Sep 2, 2016 · 3 comments
Closed

[Question] rc5 ready? #12

rmoscowitz opened this issue Sep 2, 2016 · 3 comments
Milestone

Comments

@rmoscowitz
Copy link

Sorry if I'm jumping the gun (I know you haven't updated sample-app-ng1-to-ng2 to rc5 yet). Should I be able to use ng1-to-ng2 with angular2.rc5?

I've upgraded my hybrid app to...

"@angular/common": "2.0.0-rc.5",
"@angular/compiler": "2.0.0-rc.5",
"@angular/core": "2.0.0-rc.5",
"@angular/http": "2.0.0-rc.5",
"@angular/platform-browser": "2.0.0-rc.5",
"@angular/platform-browser-dynamic": "2.0.0-rc.5",
"@angular/upgrade": "2.0.0-rc.5",
"ui-router-ng2": "1.0.0-beta.1",
"ui-router-ng1-to-ng2": "1.0.10"

I've created an NgModule (almost an exact copy/paste from quickstart-ng2) and exported the UpgradeAdapter with my module...

export const upgradeAdapter = new UpgradeAdapter(AppModule);

In my angular1 code, I've bootstrapped with my exported upgradeAdapter:

angular.element(document).ready(() => {
  upgradeAdapter.bootstrap(document.body, ['myApp', 'ui.router.upgrade']);
});

Everything compiles without error, and I'm able to get to my angular 1 routes, but I'm now getting a navigation error when trying to get to angular2 routes (worked ok with rc3).

Thanks!

@christopherthielen
Copy link
Member

It's nearly ready but I haven't pushed to master or released yet.

@christopherthielen
Copy link
Member

christopherthielen commented Sep 12, 2016

@rmoscowitz I've released a new ng1-to-ng2 1.0.11 which is compatible with angular 2.0.0-rc.5 and ui-router 1.0.0-beta.2

Because of #13 ng1-to-ng2 can't yet be compatible with rc.6.

@rmoscowitz
Copy link
Author

@christopherthielen Thanks a lot, it's working!

@christopherthielen christopherthielen added this to the 1.0.11 milestone Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants