-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -DAPP=<app_name> cmake option. Add timing info to rt logs. #477
Add -DAPP=<app_name> cmake option. Add timing info to rt logs. #477
Conversation
* Port to stampede2 for XSEDE
… applications" (#9)
Machine: gaea |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a default for APP
or should there be one? (APP=ATM
).
This PR does a ton more than what is in the title or the description. It would be great to add a bit of information so that we can find those PRs easier if needed in the future.
CI errors have to do with EC2 instance, and not ufs-weather-model. I am looking into this. |
Should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good.
One change in README.md
is requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ufs-community#477)" This reverts commit 37f0da7.
Description
Add timing info for all compile jobs to the main log file.
Fix Rocoto option.
Save timestamps for each rt job
As the number of applications within the UFS grows, this PR collects the applications and re-defines it in terms of components that need to be enabled/disabled for the application. It also allows the user the ability to define their own application based on a unique App Name.
The currently supported valid applications are:
CMake expects an option
-DAPP=<APP_NAME>
, whereAPP_NAME
is the item in the 1st column from the above table.Without a valid application, the configuration will exit with a message.
To add new applications, the user will define a unique application name in the list defined as
VALID_APPS
inCMakeLists.txt
and proceed to enable the components for the new application incmake/configure_apps.cmake
.Testing
How were these changes tested? tested on hera.intel
What compilers / HPCs was it tested with? intel
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have regression tests and unit tests (utests) been run? yes
On which platforms and with which compilers? hera, intel
Two tests failed on wcoss (fv3_gfs_v15p2 and fv3_gfs_v15p2_RRTMGP).
Dependencies
No.
Do PRs in upstream repositories need to be merged first?
No.