-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new regression tests for DATM-MOM6-CICE6 model #231
Closed
Closed
Changes from 39 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
f5d4007
Option to build coupled model
aerorahul c40c300
fix in build.sh
aerorahul 206218c
update modulefiles for orion, hera and wcoss to load pio. Make PIO o…
aerorahul 141b928
FMS needs to be linked in MOM6 objects. Add 32BIT and S2S check
aerorahul 180410a
add S2S option to MAKE_OPT
aerorahul 2bca804
upload orion and hera.intel regression logs
aerorahul 47c6aa8
update MOM6 submodule to its HEAD. hera.gnu does not have PIO module …
aerorahul fbbb557
update CMakeModule pointer
aerorahul 4681df7
update CMakeModules pointer
aerorahul fa173bb
update hera.gnu/fv3 modulefile to use hpc-stack built by NCEPLIBS tea…
aerorahul bf42ef3
add generic linux.gnu configure file
aerorahul 5b583c4
turns out there is no real difference between linux gnu and linux Intel;
aerorahul 3ab6b57
fix tabs with spaces. Enable building WW3 on generic linux and mac
aerorahul 8b6879a
@climbfuji wants to maintain separate configure files for linux, linu…
aerorahul 903cd95
apparently it is customary to have platform.compiler config file
aerorahul 3bdab1a
Merge branch 'develop' into feature/coupled
aerorahul 349f164
update gitmodules
aerorahul 0c2a863
Add standard s2s tests
DusanJovic-NOAA 47a50c4
Add tests RT for S2S from @DusanJovic-NOAA
aerorahul 991b20d
add missing -Dcoupled in CICE-interface
aerorahul 84ac096
Merge branch 'feature/coupled' of https://github.com/aerorahul/ufs-we…
aerorahul cbc0447
remove useless conf/ directory
aerorahul 51c5dab
add CICE_IO option (default: NetCDF). Add MOM6 solo executable option…
aerorahul bb5adab
add debug flags for MOM6 and CICE from @minsukji-noaa
aerorahul c5e3689
add debug modulefiles for hera, orion and wcoss_dell_p3
aerorahul cb0012d
update forgotten README.md
aerorahul 1ae4de3
skip creating OBJECT library and directly create static library. Bugf…
aerorahul 62e0461
PIO_C library is not necessary in CMEPS-interface CMakeLists.txt
aerorahul 6988543
enable VERBOSE on build only when requested. Remove -warn flags from…
aerorahul 574d26c
remove rt_s2s.conf and add S2S tests to rt.conf
aerorahul 93423d6
add DATM submodule
aerorahul 1fd235a
point to aerorahul fork of DATM
aerorahul 63268f2
update CMakeList.txt to build data atmosphere. Add compile test only…
aerorahul 2693337
Merge branch 'develop' into feature/coupled
aerorahul 302f9b3
update README.md
aerorahul 05648ec
Merge branch 'feature/coupled' into feature/datm
aerorahul b456556
Added regression tests for datm-mom6-cice6 model.
binli2337 5bf90ee
Added Hera log files.
binli2337 a2ce13b
Updated rt.sh and added Orion log files.
binli2337 0f8c560
Updated DATM and WW3.
binli2337 e6f73dc
Merge branch 'develop' into add_new_test
binli2337 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,70 @@ | ||
coupled*.mk | ||
rt.conf.single | ||
# Prerequisites | ||
*.d | ||
|
||
# Compiled Object files | ||
*.slo | ||
*.lo | ||
*.o | ||
*.obj | ||
|
||
# Precompiled Headers | ||
*.gch | ||
*.pch | ||
|
||
# Compiled Dynamic libraries | ||
*.so | ||
*.dylib | ||
*.dll | ||
|
||
# Fortran module files | ||
*.mod | ||
*.smod | ||
|
||
# Compiled Static libraries | ||
*.lai | ||
*.la | ||
*.a | ||
*.lib | ||
|
||
# Executables | ||
*.exe | ||
*.out | ||
*.app | ||
*.x | ||
|
||
# system files | ||
*.swp | ||
*~ | ||
.DS_Store | ||
|
||
# python files | ||
# Byte-compiled / optimized / DLL files | ||
__pycache__/ | ||
*.py[cod] | ||
*$py.class | ||
|
||
# CMake files and directories | ||
build*/ | ||
install*/ | ||
CMakeLists.txt.user | ||
CMakeCache.txt | ||
CMakeFiles | ||
CMakeScripts | ||
cmake_install.cmake | ||
install_manifest.txt | ||
compile_commands.json | ||
CTestTestfile.cmake | ||
_deps | ||
|
||
ufs_weather_model | ||
NEMS.exe | ||
*.exe | ||
|
||
tests/fv3_*.exe | ||
# repo-specific ignorables | ||
coupled*.mk | ||
rt.conf.single | ||
ufs_model | ||
tests/modules.fv3_* | ||
tests/ecflow_run/ | ||
tests/log_*/ | ||
tests/lock/ | ||
tests/Compile_*.log | ||
tests/fail_test | ||
log* | ||
build*.log* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
### CICE Fortran compiler flags | ||
if(CMAKE_Fortran_COMPILER_ID MATCHES "GNU") | ||
set(CMAKE_Fortran_FLAGS "-g -fbacktrace") | ||
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fconvert=big-endian -ffree-line-length-none ") | ||
set(CMAKE_Fortran_FLAGS_RELEASE "-O2") | ||
set(CMAKE_Fortran_FLAGS_DEBUG "-O0 -Wall -Wextra -fcheck=bounds -ffpe-trap=invalid,zero,overflow,underflow" ) | ||
set(CMAKE_Fortran_LINK_FLAGS "" ) | ||
elseif(CMAKE_Fortran_COMPILER_ID MATCHES "Intel") | ||
set(CMAKE_Fortran_FLAGS "-g -traceback") | ||
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -FR -convert big_endian -assume byterecl -ftz -align array64byte -xHOST") | ||
set(CMAKE_Fortran_FLAGS_RELEASE "-O2 -fp-model precise") | ||
set(CMAKE_Fortran_FLAGS_DEBUG "-O0 -check uninit -check bounds -check pointers -fpe0 -check noarg_temp_created -link_mpi=dbg") | ||
set(CMAKE_Fortran_LINK_FLAGS "") | ||
else() | ||
message(WARNING "Fortran compiler with ID ${CMAKE_Fortran_COMPILER_ID} will be used with CMake default options") | ||
endif() | ||
|
||
### CICE C compiler flags | ||
if(CMAKE_C_COMPILER_ID MATCHES "GNU") | ||
set(CMAKE_C_FLAGS "-g") | ||
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}") | ||
set(CMAKE_C_FLAGS_RELEASE "-O3") | ||
set(CMAKE_C_FLAGS_DEBUG "-O0") | ||
set(CMAKE_C_LINK_FLAGS "") | ||
elseif(CMAKE_C_COMPILER_ID MATCHES "Intel") | ||
set( CMAKE_C_FLAGS "-g -traceback") | ||
set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -xHOST") | ||
set( CMAKE_C_FLAGS_RELEASE "-O2 -fp-model precise") | ||
set( CMAKE_C_FLAGS_DEBUG "-O0 -ftrapuv") | ||
set( CMAKE_C_LINK_FLAGS "") | ||
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang") | ||
set(CMAKE_C_FLAGS "-g") | ||
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}") | ||
set( CMAKE_C_FLAGS_RELEASE "-O3" ) | ||
set( CMAKE_C_FLAGS_DEBUG "-O0" ) | ||
set( CMAKE_C_LINK_FLAGS "" ) | ||
else() | ||
message(WARNING "C compiler with ID ${CMAKE_C_COMPILER_ID} will be used with CMake default options") | ||
endif() | ||
|
||
# Configuration Options | ||
set(CICE_IO "NetCDF" CACHE STRING "CICE OPTIONS: Choose IO options.") | ||
set_property(CACHE CICE_IO PROPERTY STRINGS "NetCDF" "PIO" "Binary") | ||
|
||
# Too many files to list, so include them via this file | ||
include("cice_files.cmake") | ||
|
||
# Collect source files for library | ||
list(APPEND lib_src_files | ||
${cice_shared_files} | ||
${cice_shared_files_c} | ||
${icepack_files} | ||
${cice_mpi_comm_files} | ||
${cice_nuopc_cmeps_driver_files}) | ||
|
||
list(APPEND _cice_defs FORTRANUNDERSCORE | ||
coupled) | ||
|
||
# Select IO source files based on CICE_IO | ||
if(CICE_IO MATCHES "NetCDF") | ||
list(APPEND lib_src_files ${cice_netcdf_io_files}) | ||
list(APPEND _cice_defs USE_NETCDF) | ||
elseif(CICE_IO MATCHES "PIO") | ||
list(APPEND lib_src_files ${cice_pio2_io_files}) | ||
list(APPEND _cice_defs USE_NETCDF) | ||
elseif(CICE_IO MATCHES "Binary") | ||
list(APPEND lib_src_files ${cice_binary_io_files}) | ||
endif() | ||
|
||
### Create target library and set PUBLIC interfaces on the library | ||
add_library(cice STATIC ${lib_src_files}) | ||
set_target_properties(cice PROPERTIES Fortran_MODULE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/mod) | ||
target_compile_definitions(cice PUBLIC "${_cice_defs}") | ||
target_include_directories(cice PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod> | ||
$<INSTALL_INTERFACE:mod>) | ||
target_link_libraries(cice PUBLIC esmf) | ||
if(CICE_IO MATCHES "^(NetCDF|PIO)$") | ||
target_link_libraries(cice PUBLIC NetCDF::NetCDF_Fortran) | ||
if(CICE_IO MATCHES "PIO") | ||
target_link_libraries(cice PUBLIC PIO::PIO_Fortran) | ||
endif() | ||
endif() | ||
if(OpenMP_Fortran_FOUND) | ||
target_link_libraries(cice PRIVATE OpenMP::OpenMP_Fortran) | ||
endif() | ||
|
||
############################################################################### | ||
### Install | ||
############################################################################### | ||
|
||
install( | ||
TARGETS cice | ||
EXPORT cice-config | ||
LIBRARY DESTINATION lib | ||
ARCHIVE DESTINATION lib | ||
COMPONENT Library) | ||
|
||
install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/mod DESTINATION ${CMAKE_INSTALL_PREFIX}/CICE) | ||
|
||
install(EXPORT cice-config | ||
DESTINATION lib/cmake) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,185 @@ | ||
list(APPEND cice_shared_files | ||
#Shared List: | ||
CICE/cicecore/shared/ice_arrays_column.F90 | ||
CICE/cicecore/shared/ice_calendar.F90 | ||
CICE/cicecore/shared/ice_constants.F90 | ||
CICE/cicecore/shared/ice_distribution.F90 | ||
CICE/cicecore/shared/ice_domain_size.F90 | ||
CICE/cicecore/shared/ice_fileunits.F90 | ||
CICE/cicecore/shared/ice_init_column.F90 | ||
CICE/cicecore/shared/ice_kinds_mod.F90 | ||
CICE/cicecore/shared/ice_restart_column.F90 | ||
CICE/cicecore/shared/ice_restart_shared.F90 | ||
CICE/cicecore/shared/ice_spacecurve.F90 | ||
|
||
#Analysis List: | ||
CICE/cicecore/cicedynB/analysis/ice_diagnostics.F90 | ||
CICE/cicecore/cicedynB/analysis/ice_diagnostics_bgc.F90 | ||
CICE/cicecore/cicedynB/analysis/ice_history.F90 | ||
CICE/cicecore/cicedynB/analysis/ice_history_bgc.F90 | ||
CICE/cicecore/cicedynB/analysis/ice_history_drag.F90 | ||
CICE/cicecore/cicedynB/analysis/ice_history_fsd.F90 | ||
CICE/cicecore/cicedynB/analysis/ice_history_mechred.F90 | ||
CICE/cicecore/cicedynB/analysis/ice_history_pond.F90 | ||
CICE/cicecore/cicedynB/analysis/ice_history_shared.F90 | ||
|
||
#Dynamics List: | ||
CICE/cicecore/cicedynB/dynamics/ice_dyn_eap.F90 | ||
CICE/cicecore/cicedynB/dynamics/ice_dyn_evp.F90 | ||
CICE/cicecore/cicedynB/dynamics/ice_dyn_evp_1d.F90 | ||
CICE/cicecore/cicedynB/dynamics/ice_dyn_shared.F90 | ||
CICE/cicecore/cicedynB/dynamics/ice_transport_driver.F90 | ||
CICE/cicecore/cicedynB/dynamics/ice_transport_remap.F90 | ||
|
||
#General List: | ||
CICE/cicecore/cicedynB/general/ice_flux.F90 | ||
CICE/cicecore/cicedynB/general/ice_flux_bgc.F90 | ||
CICE/cicecore/cicedynB/general/ice_forcing.F90 | ||
CICE/cicecore/cicedynB/general/ice_forcing_bgc.F90 | ||
CICE/cicecore/cicedynB/general/ice_init.F90 | ||
CICE/cicecore/cicedynB/general/ice_state.F90 | ||
CICE/cicecore/cicedynB/general/ice_step_mod.F90 | ||
|
||
#Infrastructure List | ||
CICE/cicecore/cicedynB/infrastructure/ice_blocks.F90 | ||
CICE/cicecore/cicedynB/infrastructure/ice_domain.F90 | ||
CICE/cicecore/cicedynB/infrastructure/ice_grid.F90 | ||
CICE/cicecore/cicedynB/infrastructure/ice_read_write.F90 | ||
CICE/cicecore/cicedynB/infrastructure/ice_restart_driver.F90 | ||
CICE/cicecore/cicedynB/infrastructure/ice_restoring.F90 | ||
) | ||
|
||
|
||
#Icepack List: | ||
list(APPEND icepack_files | ||
CICE/icepack/columnphysics/icepack_aerosol.F90 | ||
CICE/icepack/columnphysics/icepack_age.F90 | ||
CICE/icepack/columnphysics/icepack_algae.F90 | ||
CICE/icepack/columnphysics/icepack_atmo.F90 | ||
CICE/icepack/columnphysics/icepack_brine.F90 | ||
CICE/icepack/columnphysics/icepack_firstyear.F90 | ||
CICE/icepack/columnphysics/icepack_flux.F90 | ||
CICE/icepack/columnphysics/icepack_fsd.F90 | ||
CICE/icepack/columnphysics/icepack_intfc.F90 | ||
CICE/icepack/columnphysics/icepack_isotope.F90 | ||
CICE/icepack/columnphysics/icepack_itd.F90 | ||
CICE/icepack/columnphysics/icepack_kinds.F90 | ||
CICE/icepack/columnphysics/icepack_mechred.F90 | ||
CICE/icepack/columnphysics/icepack_meltpond_cesm.F90 | ||
CICE/icepack/columnphysics/icepack_meltpond_lvl.F90 | ||
CICE/icepack/columnphysics/icepack_meltpond_topo.F90 | ||
CICE/icepack/columnphysics/icepack_mushy_physics.F90 | ||
CICE/icepack/columnphysics/icepack_ocean.F90 | ||
CICE/icepack/columnphysics/icepack_orbital.F90 | ||
CICE/icepack/columnphysics/icepack_parameters.F90 | ||
CICE/icepack/columnphysics/icepack_shortwave.F90 | ||
CICE/icepack/columnphysics/icepack_therm_0layer.F90 | ||
CICE/icepack/columnphysics/icepack_therm_bl99.F90 | ||
CICE/icepack/columnphysics/icepack_therm_itd.F90 | ||
CICE/icepack/columnphysics/icepack_therm_mushy.F90 | ||
CICE/icepack/columnphysics/icepack_therm_shared.F90 | ||
CICE/icepack/columnphysics/icepack_therm_vertical.F90 | ||
CICE/icepack/columnphysics/icepack_tracers.F90 | ||
CICE/icepack/columnphysics/icepack_warnings.F90 | ||
CICE/icepack/columnphysics/icepack_wavefracspec.F90 | ||
CICE/icepack/columnphysics/icepack_zbgc.F90 | ||
CICE/icepack/columnphysics/icepack_zbgc_shared.F90 | ||
CICE/icepack/columnphysics/icepack_zsalinity.F90 | ||
) | ||
|
||
list(APPEND cice_shared_files_c | ||
CICE/cicecore/cicedynB/infrastructure/ice_shr_reprosum86.c | ||
) | ||
|
||
#-- Using MPI | ||
list(APPEND cice_mpi_comm_files | ||
CICE/cicecore/cicedynB/infrastructure/comm/mpi/ice_boundary.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/mpi/ice_broadcast.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/mpi/ice_communicate.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/mpi/ice_exit.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/mpi/ice_gather_scatter.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/mpi/ice_global_reductions.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/mpi/ice_reprosum.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/mpi/ice_timers.F90 | ||
) | ||
|
||
#-- Using Serial | ||
list(APPEND cice_serial_comm_files | ||
CICE/cicecore/cicedynB/infrastructure/comm/serial/ice_boundary.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/serial/ice_broadcast.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/serial/ice_communicate.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/serial/ice_exit.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/serial/ice_gather_scatter.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/serial/ice_global_reductions.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/serial/ice_reprosum.F90 | ||
CICE/cicecore/cicedynB/infrastructure/comm/serial/ice_timers.F90 | ||
) | ||
|
||
#-- Using binary IO | ||
list(APPEND cice_binary_io_files | ||
CICE/cicecore/cicedynB/infrastructure/io/io_binary/ice_history_write.F90 | ||
CICE/cicecore/cicedynB/infrastructure/io/io_binary/ice_restart.F90 | ||
) | ||
|
||
#-- Using NetCDF IO | ||
list(APPEND cice_netcdf_io_files | ||
CICE/cicecore/cicedynB/infrastructure/io/io_netcdf/ice_history_write.F90 | ||
CICE/cicecore/cicedynB/infrastructure/io/io_netcdf/ice_restart.F90 | ||
) | ||
|
||
#PIO2 I/O List: | ||
list(APPEND cice_pio2_io_files | ||
CICE/cicecore/cicedynB/infrastructure/io/io_pio2/ice_history_write.F90 | ||
CICE/cicecore/cicedynB/infrastructure/io/io_pio2/ice_pio.F90 | ||
CICE/cicecore/cicedynB/infrastructure/io/io_pio2/ice_restart.F90 | ||
) | ||
|
||
#-- Using standalone driver | ||
list(APPEND cice_standalone_driver_files | ||
CICE/cicecore/drivers/standalone/cice/CICE.F90 | ||
CICE/cicecore/drivers/standalone/cice/CICE_FinalMod.F90 | ||
CICE/cicecore/drivers/standalone/cice/CICE_InitMod.F90 | ||
CICE/cicecore/drivers/standalone/cice/CICE_RunMod.F90 | ||
) | ||
|
||
#-- Using NUOPC CMEPS driver | ||
list(APPEND cice_nuopc_cmeps_driver_files | ||
CICE/cicecore/drivers/nuopc/cmeps/CICE_FinalMod.F90 | ||
CICE/cicecore/drivers/nuopc/cmeps/CICE_InitMod.F90 | ||
CICE/cicecore/drivers/nuopc/cmeps/CICE_RunMod.F90 | ||
CICE/cicecore/drivers/nuopc/cmeps/cice_wrapper_mod.F90 | ||
CICE/cicecore/drivers/nuopc/cmeps/ice_comp_nuopc.F90 | ||
CICE/cicecore/drivers/nuopc/cmeps/ice_import_export.F90 | ||
CICE/cicecore/drivers/nuopc/cmeps/ice_prescribed_mod.F90 | ||
CICE/cicecore/drivers/nuopc/cmeps/ice_scam.F90 | ||
CICE/cicecore/drivers/nuopc/cmeps/ice_shr_methods.F90 | ||
) | ||
|
||
#-- Using NUOPC DMI driver | ||
list(APPEND cice_nuopc_dmi_driver_files | ||
CICE/cicecore/drivers/nuopc/dmi/CICE.F90 | ||
CICE/cicecore/drivers/nuopc/dmi/CICE_FinalMod.F90 | ||
CICE/cicecore/drivers/nuopc/dmi/CICE_InitMod.F90 | ||
CICE/cicecore/drivers/nuopc/dmi/CICE_RunMod.F90 | ||
) | ||
|
||
#-- Using direct driver | ||
list(APPEND cice_direct_driver_files | ||
CICE/cicecore/drivers/direct/hadgem3/CICE.F90 | ||
CICE/cicecore/drivers/direct/hadgem3/CICE_FinalMod.F90 | ||
CICE/cicecore/drivers/direct/hadgem3/CICE_InitMod.F90 | ||
CICE/cicecore/drivers/direct/hadgem3/CICE_RunMod.F90 | ||
) | ||
|
||
#-- Using MCT driver | ||
list(APPEND cice_mct_driver_files | ||
CICE/cicecore/drivers/mct/cesm1/CICE_FinalMod.F90 | ||
CICE/cicecore/drivers/mct/cesm1/CICE_InitMod.F90 | ||
CICE/cicecore/drivers/mct/cesm1/CICE_RunMod.F90 | ||
CICE/cicecore/drivers/mct/cesm1/ice_comp_esmf.F90 | ||
CICE/cicecore/drivers/mct/cesm1/ice_comp_mct.F90 | ||
CICE/cicecore/drivers/mct/cesm1/ice_cpl_indices.F90 | ||
CICE/cicecore/drivers/mct/cesm1/ice_import_export.F90 | ||
CICE/cicecore/drivers/mct/cesm1/ice_prescribed_mod.F90 | ||
CICE/cicecore/drivers/mct/cesm1/ice_scam.F90 | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you please merge to the latest ufs-weather develop branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.