Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SPP support to G-F deep convection #1876

Merged
merged 18 commits into from
Sep 11, 2023
Merged

add SPP support to G-F deep convection #1876

merged 18 commits into from
Sep 11, 2023

Conversation

JiliDong-NOAA
Copy link
Contributor

@JiliDong-NOAA JiliDong-NOAA commented Aug 21, 2023 •
edited by FernandoAndrade-NOAA
Loading

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

  1. add stochastic parameterization perturbations support to Grell-Freitas deep convection parameterization by passing stochastic patterns to mass transport, vertical mass flux profile and closures
  2. fix reproducibility issue in G-F deep convection at high resolutions (ichoice option switched to 0)

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

fv3atm:

ccpp-physics:

stochastic_physics:

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@JiliDong-NOAA
Copy link
Contributor Author

RegressionTests_hera.log
RT on Hera log here. All passed successfully.

@JiliDong-NOAA
Copy link
Contributor Author

stochastic physics PR has been approved

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 7, 2023

stochastic physics PR has been approved

@JiliDong-NOAA thanks for the note! #1823 is on-going. We should be able to schedule to commit this PR late this afternoon or tomorrow after merging #1823.

@zach1221 zach1221 self-assigned this Sep 7, 2023
@zach1221 zach1221 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container and removed jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Sep 7, 2023
@zach1221
Copy link
Collaborator

zach1221 commented Sep 7, 2023

@JiliDong-NOAA PR#1823 is merged. Can you please sync up your branch? Then we can begin testing.

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA PR#1823 is merged. Can you please sync up your branch? Then we can begin testing.

done.

@zach1221 zach1221 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Sep 7, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

Jenkins ci logs attached, ORTs passed.
ufs-weather-model » ort-docker-pipeline » PR-1876#1 Console [Jenkins].txt

@FernandoAndrade-NOAA FernandoAndrade-NOAA added hera-RT Run Hera regression testing jet-RT Run AutoRT Jet regression testing and removed hera-RT Run Hera regression testing jet-RT Run AutoRT Jet regression testing labels Sep 8, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: jet
Job: RT
[RT] Repo location: /lfs4/HFIP/hfv3gfs/role.epic/autort/pr/1483594336/20230908073124/ufs-weather-model
Please make changes and add the following label back: jet-RT

@BrianCurtis-NOAA
Copy link
Collaborator

No Acorn today. Please skip.

@zach1221
Copy link
Collaborator

zach1221 commented Sep 8, 2023

No Acorn today. Please skip.

Thanks Brian.

@FernandoAndrade-NOAA
Copy link
Collaborator

Ok, other machines have finished their testing. This should be ready to continue the merge process, I'll leave a note in the sub PRs.

@dustinswales
Copy link
Collaborator

@FernandoAndrade-NOAA Physics merged

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 8, 2023

@JiliDong-NOAA FV3 pr was merged. Can you update hash and revert change in gitmodules? correct hash is NOAA-EMC/fv3atm@9b5825b

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA FV3 pr was merged. Can you update hash and revert change in gitmodules? correct hash is NOAA-EMC/fv3atm@9b5825b

FV3 updated.

@zach1221
Copy link
Collaborator

@JiliDong-NOAA stochastic physics PR has been merged. Please update submodule pointer and revert change in .gitmodule url.
hash: 1ee7cc9a8b5d5733b391127ca31059b497ecdea8

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA stochastic physics PR has been merged. Please update submodule pointer and revert change in .gitmodule url. hash: 1ee7cc9a8b5d5733b391127ca31059b497ecdea8

done.

@zach1221 zach1221 merged commit 04a6501 into ufs-community:develop Sep 11, 2023
@grantfirl grantfirl mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@sadeghitabas sadeghitabas Awaiting requested review from sadeghitabas

Assignees

@zach1221 zach1221

Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JiliDong-NOAA @jkbk2004 @zach1221 @FernandoAndrade-NOAA @BrianCurtis-NOAA @dustinswales @epic-cicd-jenkins