-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SW net to ocean #1773
Fix SW net to ocean #1773
Conversation
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
update cmeps build to implement check4nans feature using module stored in cdeps repo
Jenkins ci logs are attached, apologies for the delay Jenkins had to be rerun on this PR due an issue with staging the test data, should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve based on previous 8 mini testing results and today's RT test
Description
Implements the ocean albedo calculation in CMEPS to determine SWnet sent to ocean.
A configuration variable (
ocean_albedo_limit
) is added to the mediator attributes and set = 0.06 in order to match the behaviour of FV3 (see ccpp/physics/physics/GFS_surface_generic_post.F90).Two additional configuration variables (
flux_albav = true
,albdir = 0.06
) can be used to mimic the current treatement of SW net to the ocean even with the use of the mediator ocean albedo calculation.Top of commit queue on: TBD
Input data additions/changes
Anticipated changes to regression tests:
RegressionTests_hera.log
All global DATM and Coupled RTs will need new baselines. HAFS baselines do not change since the HAFS application uses SWnet from the ATM. The
atmwav_control_noaero_p8_intel
reproduces all files except for the WAV restart file.Failed tests
Subcomponents involved:
Combined with PR's (If Applicable):
Commit Queue Checklist:
Linked PR's and Issues:
Testing Day Checklist:
Testing Log (for CM's):