Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WW3 with latest develop #1710

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Apr 13, 2023

Description

Updates WW3 with recent updates from develop which include:

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Can combine with any PR that doesn't change WW3 code beyond this update.

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Closes #1551

WW3 PR: NOAA-EMC/WW3#982

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Can orion.intel replace the required hera/cheyenne.intel? The queue was faster on orion and I overlooked that it's hera specifically that was asked for here. The hera.gnu is in the queue and I will post both logs when completed.

@MatthewMasarik-NOAA is on vacation and wont be back until Monday so I wont have a review on the WW3 side complete until then.

@BrianCurtis-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA any Intel will do. Yeah Hera has my job still with 1 node waiting since about 11. Good luck with an entire GNU suite!

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 If you have some time, can you run this PR through cheyenne.gnu comparing to current baselines? Might go a LOT faster than Hera currently.

@jkbk2004
Copy link
Collaborator

@jkbk2004 If you have some time, can you run this PR through cheyenne.gnu comparing to current baselines? Might go a LOT faster than Hera currently.

sure!

@JessicaMeixner-NOAA
Copy link
Collaborator Author

RegressionTests_orion.intel.log
Here's the orion log.

@JessicaMeixner-NOAA JessicaMeixner-NOAA added the No Baseline Change No Baseline Change label Apr 13, 2023
@jkbk2004
Copy link
Collaborator

RegressionTests_cheyenne.gnu.log

@BrianCurtis-NOAA BrianCurtis-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. and removed Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Apr 14, 2023
@JessicaMeixner-NOAA
Copy link
Collaborator Author

Thanks @jkbk2004 !

@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA we are considering to combine with #1669. no baseline changes. Would that be ok?

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Sounds great!

Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review Pass

RTs Pass

Approved.

@jkbk2004
Copy link
Collaborator

merged with #1669

@jkbk2004 jkbk2004 closed this Apr 17, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the updateWW30413 branch April 19, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to point latest WW3 dev/ufs-weather-model branch with HAFSv1 needed updates
4 participants