Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rt_single function in rt.sh to parse correct .conf file #1558

Closed

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Jan 6, 2023

Description

Running single test from non-default .conf file does not work as expected, it always reads rt.conf instead of config file specified by -l flag. This PR updates rt_single function in rt.sh to use .conf if one is specified on command line using -l flag.

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

#1557
#1416

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DusanJovic-NOAA DusanJovic-NOAA added the No Baseline Change No Baseline Change label Jan 6, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

@DusanJovic-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 9, 2023

@DusanJovic-NOAA I think we can combine this pr to Sam's #1554. Can we coordinate with Sam? Once we merge in #1560, then we can try to commit #1554 today.

@DusanJovic-NOAA
Copy link
Collaborator Author

Yes, this PR can be combined with #1554

@jkbk2004
Copy link
Collaborator

merged with #1554

@jkbk2004 jkbk2004 closed this Jan 12, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the rt_single branch January 12, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants