Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust NSTF_NAME for coupled tests #879

Closed
DeniseWorthen opened this issue Oct 20, 2021 · 2 comments · Fixed by #1218
Closed

Adjust NSTF_NAME for coupled tests #879

DeniseWorthen opened this issue Oct 20, 2021 · 2 comments · Fixed by #1218
Assignees
Labels
enhancement New feature or request

Comments

@DeniseWorthen
Copy link
Collaborator

Description

The NSTF_NAME for the coupled control tests (all resolutions) uses NSTF_NAME=2,1,0,0,0. The restart tests use NSTF_NAME=2,0,0,0,0. Since the ICs used for the P7 tests do not need to spinup the nst model, we should use no-spinup for both the control and restart tests.

Solution

For coupled model, set the default value NSTF_NAME=2,0,0,0,0. Remove the setting of NSTF_NAME=2,0,0,0,0 in coupled restart tests.

@DeniseWorthen DeniseWorthen added the enhancement New feature or request label Oct 20, 2021
@DeniseWorthen DeniseWorthen self-assigned this Oct 20, 2021
@DeniseWorthen
Copy link
Collaborator Author

This change will change baselines and I believe also needs a change to the oRT setup. It was initially included in a PR some time ago but then removed because at the time we wanted to keep the baselines the same.

@DeniseWorthen
Copy link
Collaborator Author

@junwang-noaa We still require this change I think. While I could add it in the mesh cap PR, I think that PR already has enough changes. Can we plan to update in an upcoming commit that also changes baselines? I will create a PR if that is what we want to do. The change will only be in the test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant