Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIs should test NCO mode #416

Closed
danielabdi-noaa opened this issue Oct 13, 2022 · 1 comment
Closed

CIs should test NCO mode #416

danielabdi-noaa opened this issue Oct 13, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@danielabdi-noaa
Copy link
Collaborator

danielabdi-noaa commented Oct 13, 2022

Description

Currently CIs (Jenkins and Github actions) test only in "community" mode because it is easier to figure out the location and name of log files. The older NCO implementation used to store log files in the same place as Community mode so it was not difficult for the CIs to figure the state of workflow runs. However, the new NCO mode stores log files elsewhere and the names of log files also contain unique IDs making things difficult to discern. Since SRW app can now run any test case in either mode, it was easier to run all tests in "community" mode even for those test cases that are supposed to be run in NCO mode.

So currently we are exposed to the situation where a PR breaks NCO mode without the CIs noticing it.

Solution

  • Jenkins looks like the easier one to fix so that it can run a test case in NCO mode because it parses only log.launch_wflow.
  • Github actions parses FV3LAM_wflow.log etc and the code for that is not part of SRW app so it needs coordination with the github actions CI developers.

Requirements**

None

Acceptance Criteria (Definition of Done)

Modify setup_WE2E_tests.sh to run test cases in either "nco" or "community" mode, whatever is specified in the config file, instead of overriding mode to "community". Make sure all fundamental tests, currently there is on NCO test case, pass on all systems.

Dependencies (optional)

None

Alternative Solutions (optional)

Create symlinks to the log files under EXPTDIR/log with the workflow IDs removed from the names. This should allow both Jenkins and Github actions to test NCO mode properly without any changes needed on the CIs side.

@danielabdi-noaa danielabdi-noaa added the enhancement New feature or request label Oct 13, 2022
@danielabdi-noaa danielabdi-noaa self-assigned this Oct 14, 2022
@MichaelLueken
Copy link
Collaborator

Completed with #418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants