Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Python tool for get_extrnl_mdl_file tasks #681
Use Python tool for get_extrnl_mdl_file tasks #681
Changes from all commits
4715f05
7a35299
76ee572
c63d92b
101d39a
187aca9
e79bc21
c908fb2
3a91165
7faa5e7
20aca9a
ed57e56
f37e6d7
99387be
b92b7e4
5688a7e
95ab89c
e6cb24a
e7bcd72
ebca783
0d38bd6
653f2b6
b6c59b7
c43bae3
aec1c6f
18aedb4
d16fe92
ce63b19
8a4d4b6
31f6050
e06eec9
29f977f
2cf85d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we don't want to have any references to RAPX (or HRRRX) any more (in the comment).
Also, I can't remember how we decided on the
CDATE_min="2015070100"
. @JeffBeck-NOAA Do you remember? This info shows the RAP going further back.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsketefian, we must have gone back in time to see what the earliest available data were on HPSS for RAPX. Since we're moving to support only operational RAP data, I would think we could remove this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the earliest available RAP/HRRR operational data that will work might be. I am happy to remove the check altogether and let the user figure that out on their own.