Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect filename in warning message for missing noahmptable.tbl #104

Closed
SamuelTrahanNOAA opened this issue Sep 21, 2023 · 0 comments · Fixed by #106, ufs-community/ufs-weather-model#1893 or #102
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Collaborator

Description

When the model requires noahmptable.tbl, and it isn't present, the error message is wrong. The message asks for noahmptable.tb without the final l.

    inquire( file='noahmptable.tbl', exist=file_named )
    if ( file_named ) then
       open(15, file="noahmptable.tbl", status='old', form='formatted', action='read', iostat=ierr)
    else
       open(15, status='old', form='formatted', action='read', iostat=ierr)
    end if
    if ( ierr /= 0 ) then
       errmsg = 'warning: cannot find file noahmptable.tb' !<---- ERROR IS HERE
       errflg = 1
       return
!      write(*,'("warning: cannot find file noahmptable.tbl")')
    endif

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Run a NOAHMP configuration without noahmptable.tbl
  2. Get the wrong error message

Additional Context

  • Machine - N/A
  • Compiler - N/A
  • Suite Definition File or Scheme - anything that uses noahmp
  • Reference other issues or PRs in other repositories that this is related to, and how they are related.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment