Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Rocky8 on Jet #919

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Mar 14, 2024

DESCRIPTION OF CHANGES:

  • Update build module to use the Rocky8 version of spack-stack.
  • Update the ice blend regression test script to use Rocky8 versions of copygb/2 and cnvgrib.
  • Increase requested memory for one grid_gen regression test.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on Jet using Intel. Done using 92f5252.
  • Run unit tests locally on Jet. Done using 92f5252. All tests passed.
  • Run all consistency tests on Jet. Done using 92f5252. All tests passed except one chgres_cube test. Details below.

Additional tests using 92f5252:

  • Successfully created a C96 grid using ./driver_scripts/driver_grid.jet.sh.
  • Successfully ran the weight_gen utility (./util/weight_gen)
  • Successfully ran the gdas_init utility to produce coldstart files for a GFS 2024/03/06/06z case (./util/gdas_init)

DEPENDENCIES:

None.

DOCUMENTATION:

N/A

ISSUE:

Fixes #918.

Update ice blend regression test script to use Rocky8
versions of copygb and cnvgrib.

Increase requested memory for one grid_gen regression test.

Fixes ufs-community#918.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

GeorgeGayno-NOAA commented Mar 14, 2024

The C96 FV3 GAUSSIAN NETCDF2WAM test failed. Here are the atmospheric coldstart record differences for tile2 (other tiles showed similar differences).

CHECK out.atm.tile2.nc
+ nccmp -dmfqS out.atm.tile2.nc /lfs4/HFIP/hfv3gfs/emc.nemspara/role.ufsutils/ufs_utils/reg_tests/chgres_cube/baseline_data/c96_fv3_netcdf2wam/out.atm.tile2.nc
Variable Group Count         Sum      AbsSum          Min         Max       Range        Mean      StdDev
zh       /       147     0.71875     2.78125     -0.03125      0.0625     0.09375  0.00488946   0.0205525
t        /       116  0.00177002   0.0108643 -0.000213623 0.000305176 0.000518799 1.52588e-05 0.000107727
spo      /       740  5.9897e-06 4.46057e-05 -9.23872e-07 9.23872e-07 1.84774e-06 8.09418e-09 1.76026e-07
spo2     /      1819 2.91008e-06 3.15223e-05 -5.51343e-07 6.70552e-07  1.2219e-06 1.59982e-09 4.00122e-08

I can't explain these differences. However, they are very small compared to the average value. For example, the mean temperature difference is on order of 0.00001 K. I don't this is a problem.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review March 14, 2024 14:54
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I verified a test build and a test run of gdas_init. Approve.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 1ffaf1f into ufs-community:develop Mar 14, 2024
4 checks passed
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the jet_rocky8 branch April 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Rocky8 on Jet
2 participants