From 1aab7a22f56102eebf81014740ff025742327658 Mon Sep 17 00:00:00 2001 From: George Gayno Date: Mon, 17 Apr 2023 20:16:35 +0000 Subject: [PATCH 1/7] Some template updates. Fixes #811. --- .github/PULL_REQUEST_TEMPLATE | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index d465e2413..cf29c4fce 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -14,7 +14,9 @@ One or more paragraphs describing the problem, solution, and required changes. ## TESTS CONDUCTED: -State whether the contingency tests were run or are pending, and if they were already run, state the result. If contingency test baselines need to be updated as a result of this PR, please specify the machine(s) and path(s) to the new files. Note that running the contigency tests is required for every PR and should be run at least once after all commits or changes have been made after review of the PR. Make note of the compilers used, the platform/machine, and other relevant details as necessary. Please also note whether new unit tests or updates to existing ones were required and their file names. +The tests below must be conducted before merging. + +- [ ] Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2). ## DEPENDENCIES: Add any links to pending PRs that are required prior to merging this PR. For example: From a5d6274841763339d0007fb692798da92801ad05 Mon Sep 17 00:00:00 2001 From: George Gayno Date: Mon, 17 Apr 2023 20:21:23 +0000 Subject: [PATCH 2/7] Rename template. Fixes #811. --- .github/{PULL_REQUEST_TEMPLATE => PULL_REQUEST_TEMPLATE.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{PULL_REQUEST_TEMPLATE => PULL_REQUEST_TEMPLATE.md} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE rename to .github/PULL_REQUEST_TEMPLATE.md From 4a4e8b7988501a711d28c78a6a30bbe360f7195d Mon Sep 17 00:00:00 2001 From: George Gayno Date: Mon, 17 Apr 2023 20:25:15 +0000 Subject: [PATCH 3/7] Format change. Fixes #811. --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cf29c4fce..28a2ae446 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,7 +8,7 @@ - Use the "Preview" tab to see what your PR will look like when you hit "Create pull request" -# --- Delete this line and those above before hitting "Create pull request" --- +## --- Delete this line and those above before hitting "Create pull request" --- ## DESCRIPTION OF CHANGES: One or more paragraphs describing the problem, solution, and required changes. From fc75f43140c495c3cfe493f43cc3df63c7d25bc0 Mon Sep 17 00:00:00 2001 From: George Gayno Date: Mon, 17 Apr 2023 20:36:13 +0000 Subject: [PATCH 4/7] Add more required tests. Fixes #811. --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 28a2ae446..0e3b9a2e9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,15 +8,21 @@ - Use the "Preview" tab to see what your PR will look like when you hit "Create pull request" -## --- Delete this line and those above before hitting "Create pull request" --- +## -- Delete this line and those above before hitting "Create pull request" -- ## DESCRIPTION OF CHANGES: One or more paragraphs describing the problem, solution, and required changes. ## TESTS CONDUCTED: -The tests below must be conducted before merging. +The tests below must be conducted before merging. Contact a repository manager if you need assistance. - [ ] Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2). +- [ ] Compile branch on Hera using GNU. +- [ ] Compile branch in 'Debug' mode on WCOSS2. +- [ ] Run unit tests locally on any Tier 1 machine. +- [ ] Run relevant consistency tests locally on all Tier 1 machine. + +Describe any additional tests performed. ## DEPENDENCIES: Add any links to pending PRs that are required prior to merging this PR. For example: From 3bde0c32a2759df224241098b865eca3c9061128 Mon Sep 17 00:00:00 2001 From: George Gayno Date: Tue, 18 Apr 2023 12:58:22 +0000 Subject: [PATCH 5/7] Minor edit. Fixes #811. --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0e3b9a2e9..3f143fb46 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,7 +8,7 @@ - Use the "Preview" tab to see what your PR will look like when you hit "Create pull request" -## -- Delete this line and those above before hitting "Create pull request" -- +## --- Delete this line and those above before hitting "Create pull request" --- ## DESCRIPTION OF CHANGES: One or more paragraphs describing the problem, solution, and required changes. From 747c5bb412664831ecf0cc00586dcb614632ce59 Mon Sep 17 00:00:00 2001 From: George Gayno Date: Tue, 18 Apr 2023 12:59:28 +0000 Subject: [PATCH 6/7] Revert name of template. Fixes #811. --- .github/{PULL_REQUEST_TEMPLATE.md => PULL_REQUEST_TEMPLATE} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{PULL_REQUEST_TEMPLATE.md => PULL_REQUEST_TEMPLATE} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE.md rename to .github/PULL_REQUEST_TEMPLATE From 376e883d74833fc0d09bfc4e7d4d9516071dd2d7 Mon Sep 17 00:00:00 2001 From: George Gayno Date: Tue, 18 Apr 2023 13:11:40 +0000 Subject: [PATCH 7/7] Minor wording changes. Fixes #811. --- .github/PULL_REQUEST_TEMPLATE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index 3f143fb46..7a696e24f 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -14,7 +14,7 @@ One or more paragraphs describing the problem, solution, and required changes. ## TESTS CONDUCTED: -The tests below must be conducted before merging. Contact a repository manager if you need assistance. +If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance. - [ ] Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2). - [ ] Compile branch on Hera using GNU.