Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assert_encode macro to simplify tests #163

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Conversation

mruoss
Copy link
Collaborator

@mruoss mruoss commented Oct 17, 2023

Macro to test for output but also for identity after encoding => parsing.
Also fixed two tests that failed after adding the macro.


Requirements

  • Entry in CHANGELOG.md was created
  • Link to documentation on https://yaml.org/ is provided in the PR description
  • Functionality is covered by newly created tests

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Pull Request Test Coverage Report for Build b335befec6e1d2ba59cc8d397da9777b1ee00fe5-PR-163

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 09b86fd512f708d18d045a5dc26e647f7ef0ec1f: 0.0%
Covered Lines: 109
Relevant Lines: 109

💛 - Coveralls

@mruoss mruoss force-pushed the add-assert_encode-macro branch 2 times, most recently from a4c35ae to a5c4918 Compare October 17, 2023 18:52
@mruoss mruoss force-pushed the add-assert_encode-macro branch from 06497d7 to 570054f Compare October 17, 2023 20:13
@mruoss mruoss requested a review from jlgeering October 17, 2023 20:17
@mruoss mruoss force-pushed the add-assert_encode-macro branch 8 times, most recently from 9c4b652 to b335bef Compare October 18, 2023 20:54
@mruoss mruoss force-pushed the add-assert_encode-macro branch from b335bef to fbec1af Compare October 18, 2023 20:55
Copy link
Collaborator

@jlgeering jlgeering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlgeering jlgeering merged commit 5383911 into main Oct 18, 2023
@jlgeering jlgeering deleted the add-assert_encode-macro branch October 20, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants