Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote values with an initial ":{" #141

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

adamwight
Copy link
Contributor

This combination is parsed as syntax by yamlerl and possibly other decoders, so we should quote when emitting for better compatibility.

Closes #140 . This is outside of the spec, but makes the output more robust.


Requirements

  • Entry in CHANGELOG.md was created
  • Link to documentation on https://yaml.org/ is provided in the PR description
  • Functionality is covered by newly created tests

This combination is parsed as syntax by yamlerl and possibly other
decoders, so we should quote when emitting for better compatibility.
@mruoss
Copy link
Collaborator

mruoss commented Jul 14, 2023

Nice. Thanks @adamwight. You need this released asap?

@mruoss mruoss merged commit 789c418 into ufirstgroup:main Jul 14, 2023
@coveralls
Copy link

coveralls commented Nov 16, 2024

Pull Request Test Coverage Report for Build 0884859361ba33597ad560a18b6c2a1e63521a05-PR-141

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build b38c2e9de29166947bd24f5d101775975c8312b6: 0.0%
Covered Lines: 106
Relevant Lines: 106

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Produces incompatible output when indicator characters appear without quoting
3 participants