impl FusedFuture on Unordered::next #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholk
approved these changes
Apr 27, 2022
udoprog
requested changes
Apr 28, 2022
udoprog
approved these changes
Apr 28, 2022
|
Thank you! |
|
Thanks for the quick review + merge! Any chance you could push out a point-release with this change? It's no big rush or anything, so if you'd rather lump it in with a larger change, that's fine too. |
|
Yeah, of course. Shipped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Note: I had to switch
next()over from anasyncfunction returning an anonymous future, to a sync function returning an explicit future. This is because leaving it as anasyncfunction doesn't propagate the newFusedFutureimpl from the innerNextfuture on to the returned anonymous future.Alternatively, if we really don't want to leak the
Nexttype, we could change the signature to return animpl Future<Output = Option<<Self as PollNext>::Item>> + FusedFuture + 'a, but that's a real mouthful...