-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FromIterator<F> for Unicycle<F> would be more ergonomic #2
Labels
enhancement
New feature or request
Comments
Thanks for the report! They could be improved to take [Iterator::size_hint] into account to pre-allocate the collections used, so I've opened #3 to track this. |
Can you share an example of using this? Thanks! |
Hey @wysenynja I added an example here: https://github.com/udoprog/unicycle/blob/master/src/lib.rs#L54 Does that help? |
Yes. Thank you!
… On Mar 17, 2020, at 9:31 PM, John-John Tedro ***@***.***> wrote:
Hey @wysenynja <https://github.com/WyseNynja>
I added an example here: https://github.com/udoprog/unicycle/blob/master/src/lib.rs#L54 <https://github.com/udoprog/unicycle/blob/master/src/lib.rs#L54>
Does that help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYMXLVVHUCEGB4Y4S7MJTRIBFDVANCNFSM4KN5SNCQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tested one case, and I suspect it will be a common pattern for users to want to drop in
Unicycle
whereFuturesUnordered
was previously used. TheUnicyle
would have been a drop in replacement if it implementedFromIterator
likeFuturesUnordered
does, allowing it to be assembled viastd::iter::Iterator::collect
.The text was updated successfully, but these errors were encountered: