Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify -help actually match letter #307

Closed
gcode-importer opened this issue Mar 24, 2014 · 3 comments
Closed

Verify -help actually match letter #307

gcode-importer opened this issue Mar 24, 2014 · 3 comments
Assignees
Milestone

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 307

Make sure that opj_compress and opj_decompress have proper help message box.

Reported by malaterre on 2014-03-24 14:54:02

@gcode-importer
Copy link
Author

Check f/F/q

Reported by malaterre on 2014-03-24 14:55:33

@gcode-importer
Copy link
Author

I do not see anything wrong with:

        case 'r':           /* rates rates/distorsion */
        {
            char *s = opj_optarg;
            parameters->tcp_numlayers = 0;
            while (sscanf(s, "%f", &parameters->tcp_rates[parameters->tcp_numlayers])
== 1) {
                parameters->tcp_numlayers++;
                while (*s && *s != ',') {
                    s++;
                }
                if (!*s)
                    break;
                s++;
            }
            parameters->cp_disto_alloc = 1;
        }


vs:

        case 'q':           /* add fixed_quality */
        {
            char *s = opj_optarg;
            while (sscanf(s, "%f", &parameters->tcp_distoratio[parameters->tcp_numlayers])
== 1) {
                parameters->tcp_numlayers++;
                while (*s && *s != ',') {
                    s++;
                }
                if (!*s)
                    break;
                s++;
            }
            parameters->cp_fixed_quality = 1;
        }

Reported by malaterre on 2014-03-25 09:57:40

  • Status changed: Started

@gcode-importer
Copy link
Author

This was the mail that made me think that options were not correctly used : 
https://groups.google.com/d/msg/openjpeg/oPSoy-y0RoE/PJuUNZbauj8J

But it appears everything is fine.

An update from 15/01 shows that there is another issue : options -s and -q cannot be
used together. Fixed this and create new issue.
http://ericportis.com/posts/2014/resolution-progressive-jpeg2000-performance/

Reported by detonin on 2014-03-25 10:26:33

  • Status changed: Invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants