Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building 64bit version has lots of warnings #244

Closed
gcode-importer opened this issue Oct 8, 2013 · 7 comments
Closed

building 64bit version has lots of warnings #244

gcode-importer opened this issue Oct 8, 2013 · 7 comments
Assignees
Milestone

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 244

If the build target is 64bit, OPJ_SIZE_T is also 64bit. This value is often assigned
to a OPJ_UINT32 which causes compile warnings.

Attached is a diff patch that cleans up those warnings by adding an explicit cast.



Reported by brta.enfocus on 2013-10-08 12:33:26

@gcode-importer
Copy link
Author

Added attachment mentioned in description.

Reported by brta.enfocus on 2013-10-08 12:34:29


- _Attachment: [remove compiler warnings](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-244/comment-1/remove compiler warnings)_

@gcode-importer
Copy link
Author

Could you please provide a unified diff please ?

$ patch --verbose -p1 --dry-run < /tmp/remove\ compiler\ warnings 
Hmm...patch unexpectedly ends in middle of line
  I can't seem to find a patch in there anywhere.
patch: **** Only garbage was found in the patch input.

Reported by malaterre on 2014-02-24 08:41:13

@gcode-importer
Copy link
Author

Reported by malaterre on 2014-02-25 15:56:18

  • Labels added: Milestone-Release2.1

@gcode-importer
Copy link
Author

marking as wontfix until OP update status. thanks.

Reported by malaterre on 2014-03-03 11:53:49

  • Status changed: WontFix

@gcode-importer
Copy link
Author

New patches created with commands
diff -ru Patched/src/lib/openjp2/image.c Original/src/lib/openjp2/image.c > Issue244-Patch2.txt
diff -ru Patched/src/lib/openjp2/j2k.c Original/src/lib/openjp2/j2k.c > Issue244-Patch2b.txt
diff -ru Patched/src/lib/openjp2/jp2.c Original/src/lib/openjp2/jp2.c > Issue244-Patch2c.txt
diff -ru Patched/src/lib/openjp2/mqc.c Original/src/lib/openjp2/mqc.c > Issue244-Patch2d.txt
diff -ur diff -r Patched/src/lib/openjp2/raw.c Original/src/lib/openjp2/raw.c
diff -ru Patched/src/lib/openjp2/raw.c Original/src/lib/openjp2/raw.c > Issue244-Patch2e.txt
diff -ru Patched/src/lib/openjp2/t2.c Original/src/lib/openjp2/t2.c > Issue244-Patch2f.txt

Reported by brta.enfocus on 2014-07-07 10:02:33


- _Attachment: [Patches.zip](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-244/comment-5/Patches.zip)_

@gcode-importer
Copy link
Author

Reported by detonin on 2014-07-08 11:43:32

  • Status changed: Accepted

@rouault
Copy link
Collaborator

rouault commented Jul 29, 2017

Current master builds without warning on 64 bit

@rouault rouault closed this as completed Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants