Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop archive needs accessibility improvements #229

Closed
7 tasks done
TimothyGu opened this issue May 30, 2021 · 0 comments · Fixed by #373
Closed
7 tasks done

Workshop archive needs accessibility improvements #229

TimothyGu opened this issue May 30, 2021 · 0 comments · Fixed by #373
Assignees

Comments

@TimothyGu
Copy link
Contributor

TimothyGu commented May 30, 2021

  • Quarter headings and event headings are both h2s. This is confusing, since events are subordinate to quarters. Event headings should be h3, while individual sessions of the event should be h4.

  • It's not clear to accessibility technologies (AT) that tags should be treated as tags. Even though they are visually displayed as pills, AT don't know that, and tags appear as merely a heap of words.

    • We need to add role="list" to containers of a collection of tags, and role="listitem" to each tag.
    • We need to add aria-label="Tags" to containers of a collection of tags.
  • The "launch" button next to each event heading is an HTML label element. The label element should only be used in forms, not for a link.

    image

  • The accordion buttons have a weird label. We should make sure neither "Launch" nor "javascript" is included in the label for that button.

    image

  • It's unclear to AT what the div for each event is. As far as it sees, the div is just a generic container. We need to add aria-label or aria-labelled-by with the title of the event.

    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants