Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otter assign skips Gradescope username/password request even when token is set to None or null #361

Closed
champoll opened this issue Aug 30, 2021 · 1 comment · Fixed by #374
Labels
bug Something isn't working
Milestone

Comments

@champoll
Copy link

Describe the bug
When the notebook metadata contains the line token: '' , otter assign does not ask for the Gradescope username/password. The same is true if the line token: None or token: null.

To Reproduce
Add the line above to the metadata of a notebook and run "otter assign" on the notebook.

Expected behavior
Since Gradescope tokens are nonempty strings, in all these cases otter assign should assume that a Gradescope token has not been specified, and should ask for Gradescope username/password.

Versions
Python version: 3.8.5
Otter-Grader version: 3.0.6

Additional context
A workaround is to comment out the line. However, I am trying to create a file that contains all of the metadata settings and it would be convenient to be able to include the "token" line.

@champoll champoll added the bug Something isn't working label Aug 30, 2021
@chrispyles
Copy link
Member

Implemented a fix in #374 which will be included in v3.1.0.

@chrispyles chrispyles added this to the v3.1.0 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants