Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLT and LGT models cannot handle negative response values #458

Closed
Okroshiashvili opened this issue Jun 22, 2021 · 3 comments · Fixed by #459
Closed

DLT and LGT models cannot handle negative response values #458

Okroshiashvili opened this issue Jun 22, 2021 · 3 comments · Fixed by #459
Labels
bug Something isn't working

Comments

@Okroshiashvili
Copy link
Contributor

Describe the bug
In the documentation you mention that LGT cannot handle negative values of response variable. However, I encountered the same error using DLT model.

Does DLT handle negative values in response variable?

Screenshots
DLT model

image

I have same error when using LGT model

Environment (please complete the following information):

  • OS: Ubuntu 18.04
  • Python Version: 3.7

Additional context

I use Orbit version 1.0.14dev

@Okroshiashvili Okroshiashvili added the bug Something isn't working label Jun 22, 2021
@wangzhishi
Copy link
Contributor

@Okroshiashvili just to confirm before we proceed to fix this bug, are the values in your response variable all negative?

@Okroshiashvili
Copy link
Contributor Author

Hi @wangzhishi .Yes, all values in response are negative. To reproduce the behavior, sample random variables in (0, 1] interval and then take natural logarithm.

@wangzhishi
Copy link
Contributor

we merged a PR to dev branch to solve this bug. please try it out. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants