Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove component weights and version:VERSION #66

Merged
merged 1 commit into from
Aug 31, 2023
Merged

remove component weights and version:VERSION #66

merged 1 commit into from
Aug 31, 2023

Conversation

joelpittet
Copy link
Collaborator

No description provided.

@joelpittet joelpittet requested a review from occupant August 30, 2023 00:28
@joelpittet
Copy link
Collaborator Author

@occupant This is to clean up the libraries file. The default component value is 0 weight. But maybe there was a reason for that?

occupant
occupant approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@occupant occupant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I left the inherited version and weight values from classy, but this is better. Also removing the version number will mean that this doesn't require incrementing on a new release

@occupant occupant merged commit 6c49a37 into master Aug 31, 2023
@joelpittet joelpittet deleted the feature/remove-library-weight-and-version branch August 31, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@occupant occupant occupant approved these changes

Assignees

@occupant occupant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelpittet @occupant