Add header and footer regions from default drupal core #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem/Motivation:
When switching from theme inheritance with a base theme of
galactus
to starterkit fork, the regions don't match well becausegalactus
defined regions aren't inherited: https://www.drupal.org/docs/theming-drupal/sub-theme-inheritanceProposed Solution:
From the default regions in core and the page.html.twig file suggests a
page.header
andpage.footer
region will exist and we should add them to thepage.html.twig
template and info file..public/core/lib/Drupal/Core/Extension/ThemeExtensionList.php:26
The page_top, page_bottom are the only other ones in there but they get easily confused with the html.html.twig variables, so opted not to include them.